Skip to content

feat(github): use GitHub Apps instead of GitHub Deploy Keys for pushes#452

Merged
TrueBrain merged 1 commit intomainfrom
askpass-support
May 24, 2023
Merged

feat(github): use GitHub Apps instead of GitHub Deploy Keys for pushes#452
TrueBrain merged 1 commit intomainfrom
askpass-support

Conversation

@TrueBrain
Copy link
Copy Markdown
Owner

This allows for deployments that only work over HTTPS, and cannot use SSH. Deploy Keys are still easier to install, but GitHub Apps are now possible too.

@TrueBrain TrueBrain force-pushed the askpass-support branch 2 times, most recently from 558a623 to f0f31b7 Compare May 22, 2023 10:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2023

Codecov Report

Patch coverage: 53.24% and project coverage change: -0.81 ⚠️

Comparison is base (9f81a99) 84.76% compared to head (c9e5f6d) 83.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   84.76%   83.95%   -0.81%     
==========================================
  Files          51       52       +1     
  Lines        2691     2749      +58     
  Branches      416      427      +11     
==========================================
+ Hits         2281     2308      +27     
- Misses        303      333      +30     
- Partials      107      108       +1     
Impacted Files Coverage Δ
truewiki/storage/github-askpass.py 0.00% <0.00%> (ø)
truewiki/storage/github.py 82.64% <84.61%> (+3.69%) ⬆️
truewiki/storage/git.py 90.26% <100.00%> (+0.17%) ⬆️
truewiki/storage/gitlab.py 89.83% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TrueBrain TrueBrain force-pushed the askpass-support branch 23 times, most recently from 8948080 to 09715d2 Compare May 22, 2023 14:48
This allows for deployments that only work over HTTPS, and cannot
use SSH. Deploy Keys are still easier to install, but GitHub Apps
are now possible too.
@TrueBrain TrueBrain merged commit 815de50 into main May 24, 2023
@TrueBrain TrueBrain deleted the askpass-support branch May 24, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants