Skip to content

Fix: import a non-empty data-folder on first-start for github/gitlab storage backend#352

Merged
TrueBrain merged 1 commit intomainfrom
import-git
Aug 1, 2022
Merged

Fix: import a non-empty data-folder on first-start for github/gitlab storage backend#352
TrueBrain merged 1 commit intomainfrom
import-git

Conversation

@TrueBrain
Copy link
Copy Markdown
Owner

Before it assumed the remote branch already existed, and would
use that as template. But if that isn't the case, import the
current data folder, and create the remote branch.

This is mostly meant to allow end-to-end testing, which has
already some content in the data-folder.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@f65f52a). Click here to learn what that means.
The diff coverage is 12.50%.

❗ Current head 3a48011 differs from pull request most recent head 240ff5f. Consider uploading reports for the commit 240ff5f to get more accurate results

@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage        ?   80.44%           
=======================================
  Files           ?       51           
  Lines           ?     2685           
  Branches        ?      437           
=======================================
  Hits            ?     2160           
  Misses          ?      430           
  Partials        ?       95           
Impacted Files Coverage Δ
truewiki/storage/git.py 33.94% <ø> (ø)
truewiki/storage/gitlab.py 60.34% <0.00%> (ø)
truewiki/storage/github.py 40.42% <14.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65f52a...240ff5f. Read the comment docs.

…storage backend

Before it assumed the remote branch already existed, and would
use that as template. But if that isn't the case, import the
current data folder, and create the remote branch.

This is mostly meant to allow end-to-end testing, which has
already some content in the data-folder.
@TrueBrain TrueBrain merged commit 95bd378 into main Aug 1, 2022
@TrueBrain TrueBrain deleted the import-git branch August 1, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants