Fix: quickly adding and removing a page crashed the server#351
Merged
Fix: quickly adding and removing a page crashed the server#351
Conversation
Because commits are queued, and if remotes are slow, they can stack up. This makes it possible to add a page and remove one, before it is committed. In result, when the commit is actually being executed, it tried to add (or remove) a file that no longer exists. Solve this by simply ignoring these events, are they will be fixed by the next commit in the queue. Sadly, it does mean we lose a bit of history, but .. yeah, not much we can do about that.
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 80.53% 80.35% -0.18%
==========================================
Files 51 51
Lines 2682 2688 +6
Branches 436 436
==========================================
Hits 2160 2160
- Misses 427 433 +6
Partials 95 95
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because commits are queued, and if remotes are slow, they can
stack up. This makes it possible to add a page and remove one,
before it is committed. In result, when the commit is actually
being executed, it tried to add (or remove) a file that no longer
exists.
Solve this by simply ignoring these events, are they will be
fixed by the next commit in the queue. Sadly, it does mean we
lose a bit of history, but .. yeah, not much we can do about
that.