Fix: git-storage-backend could try to commit several commits at once#350
Merged
Fix: git-storage-backend could try to commit several commits at once#350
Conversation
There was an attempt to prevent that, but sadly, an Event was used instead of a Lock. This meant that when the first commit returned, all other pending were going through after that, instead of one by one. Lock is fair, as in, the first to acquire is the first to be released.
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 80.53% 80.49% -0.04%
==========================================
Files 51 51
Lines 2682 2682
Branches 436 436
==========================================
- Hits 2160 2159 -1
- Misses 427 428 +1
Partials 95 95
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an attempt to prevent that, but sadly, an Event was
used instead of a Lock. This meant that when the first commit
returned, all other pending were going through after that, instead
of one by one.
Lock is fair, as in, the first to acquire is the first to be released.