Fix: editing a page quickly after editing told you it was edited by someone else#349
Merged
Fix: editing a page quickly after editing told you it was edited by someone else#349
Conversation
…omeone else This happened because the commit was still pending, so the nonce was based on the old hash. Especially if there are a few commits pending to be processed, this could easily happen. By switching to modified-time of the file, like the local storage backend does, we solve this problem. And it is safe, as TrueWiki cannot scale out anyway for nodes that allow editing.
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 80.53% 80.57% +0.03%
==========================================
Files 51 51
Lines 2682 2682
Branches 436 437 +1
==========================================
+ Hits 2160 2161 +1
+ Misses 427 426 -1
Partials 95 95
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened because the commit was still pending, so the nonce
was based on the old hash. Especially if there are a few commits
pending to be processed, this could easily happen.
By switching to modified-time of the file, like the local storage
backend does, we solve this problem. And it is safe, as TrueWiki
cannot scale out anyway for nodes that allow editing.