Do not violate rule G-4320 in Examples of G-3145

The examples in [G-3145: Avoid using SELECT * directly from a table or view.](https://github.com/Trivadis/plsql-and-sql-coding-guidelines/blob/v4.1/docs/4-language-usage/3-dml-and-sql/1-general/g-3145.md) violate rule [G-4320: Always label your loops.](https://trivadis.github.io/plsql-and-sql-coding-guidelines/v4.1/4-language-usage/4-control-structures/3-flow-control/g-4320/).

Here's the suggested solution for bad example:

```sql
begin
   <<raise_salary>>
   for r_employee in (
      select *
        from employees
   )
   loop
      employee_api.calculate_raise_by_seniority(
         id_in       => r_employee.id
        ,salary_in   => r_employee.salary
        ,hiredate_in => r_employee.hiredate
      );
   end loop raise_salary;
end;
/
```

and here the suggested solution for the good example:

```sql
begin
   <<raise_salary>>
   for r_employee in (
      select id,salary,hiredate
        from employees
   )
   loop
      employee_api.calculate_raise_by_seniority(
         id_in       => r_employee.id
        ,salary_in   => r_employee.salary
        ,hiredate_in => r_employee.hiredate
      );
   end loop raise_salary;
end;
/ 
```


Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not violate rule G-4320 in Examples of G-3145 #134

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Do not violate rule G-4320 in Examples of G-3145 #134

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions