Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

fix(move_block): move multiple lines up/down#2220

Merged
eliandoran merged 5 commits intodevelopfrom
moveupdown
Jun 11, 2025
Merged

fix(move_block): move multiple lines up/down#2220
eliandoran merged 5 commits intodevelopfrom
moveupdown

Conversation

@SiriusXT
Copy link
Copy Markdown
Member

@SiriusXT SiriusXT commented Jun 8, 2025

Closes TriliumNext/Trilium#5787

  1. Solve moving multiple lines of plain text/headings while preserving the selection
  2. Keep moved blocks in view
  3. fix(move_block): Make the object movable – When moving near objects (e.g. tables or horizontal lines), the selection was lost and Ctrl+Up/Down fell back to cursor movement. Upgraded the shortcut‐listening approach and enabled moving of objects, block quotes, etc.
  4. Move objects/tables/texts simultaneously

@SiriusXT SiriusXT marked this pull request as ready for review June 9, 2025 02:26
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 9, 2025
@SiriusXT SiriusXT marked this pull request as draft June 10, 2025 01:51
@eliandoran
Copy link
Copy Markdown
Contributor

@SiriusXT , do you need any support for this PR?

@SiriusXT
Copy link
Copy Markdown
Member Author

SiriusXT commented Jun 10, 2025

@SiriusXT , do you need any support for this PR?

@eliandoran Currently, the movement of basic blocks has been solved, but there is still no good method for moving elements like Mermaid.
At present, elements like Mermaid can only be moved individually and cannot be mixed with other elements.
If you can solve this, that would be great. Otherwise, we can leave it for future.

@eliandoran
Copy link
Copy Markdown
Contributor

@SiriusXT , we can ignore the issue with moving widgets such as Mermaid, for now.

@SiriusXT SiriusXT marked this pull request as ready for review June 10, 2025 11:11
Copy link
Copy Markdown
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and feels pretty good!

@eliandoran eliandoran added this to the v0.95.0 milestone Jun 11, 2025
@eliandoran eliandoran merged commit cfd68f4 into develop Jun 11, 2025
10 checks passed
@eliandoran eliandoran deleted the moveupdown branch June 11, 2025 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text notes: selection gets incomplete when moving multiple lines up/down

2 participants