This repository was archived by the owner on Jun 24, 2025. It is now read-only.
feat(math): support multi-line formula editing#2003
Merged
eliandoran merged 5 commits intodevelopfrom May 26, 2025
Merged
Conversation
|
eliandoran
suggested changes
May 25, 2025
Contributor
There was a problem hiding this comment.
First, I'm really glad to see the monorepo bear fruit, with changes to the CKEditor plugins.
It looks pretty good but there's two topics to address:
-
I think we need to figure out a way to actually store the newlines entered as part of the equation since they are lost if you refresh the page or go to another note. This would especially by relevant for big equations where whitespace might play a role such as in matrices.
-
I would personally make the textbox slightly wider by default, like this:
Member
Author
|
Really appreciate the move to a monorepo — it’s made editing these plugins so much more convenient! |
eliandoran
approved these changes
May 26, 2025
Contributor
|
Great job. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to :
TriliumNext/Trilium#2088
https://github.com/orgs/TriliumNext/discussions/1731
This issue has also existed in ckeditor5-math for years without being resolved, so it is directly fixed in this repository.
Before:
After:
