This repository was archived by the owner on Jun 24, 2025. It is now read-only.
Fix incorrect import of multiple inline math.#1906
Merged
eliandoran merged 4 commits intodevelopfrom May 12, 2025
Merged
Conversation
|
eliandoran
suggested changes
May 10, 2025
Contributor
eliandoran
left a comment
There was a problem hiding this comment.
Please add a test case in markdown.spec.ts that was failing in the previous implementation and passes on the new one.
eliandoran
suggested changes
May 11, 2025
Comment on lines
+1225
to
+1227
| ::selection { | ||
| background-color: #3399FF70; | ||
| } |
Contributor
There was a problem hiding this comment.
Unfortunately, I believe this change is too specific. We can't use hard-coded colors here since they can differ between dark and light mode and we generally set up a CSS variable instead so that it can be overridden in themes.
Is there any other way?
Also, not sure exactly how it relates to the rest of the PR.
Member
Author
There was a problem hiding this comment.
I understand your point. Since this change was quite minor, I included the background adjustment in this PR as a convenience. I've reverted it for now and will look into a suitable solution.
eliandoran
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue where multiple formulas on a single line are incorrectly treated as one when importing Markdown from the clipboard.
A test case: