This repository was archived by the owner on Jun 24, 2025. It is now read-only.
Make it show which node triggered the event when right-clicking on tree#1861
Merged
eliandoran merged 4 commits intodevelopfrom May 10, 2025
Merged
Make it show which node triggered the event when right-clicking on tree#1861eliandoran merged 4 commits intodevelopfrom
eliandoran merged 4 commits intodevelopfrom
Conversation
|
eliandoran
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when right-clicking on the tree, it was unclear which item triggered the event. Now, a shadow is shown on the target item to indicate the source of the event.
For example, the image above shows that the context menu was triggered by the "word count widget".
In addition,
if (Date.now() - this.dateContextMenuOpenedMs > 300)was removed. Related to Note tree context menu closes immediately (Firefox-Ubuntu) Trilium#468Based on testing, in Firefox 66, right-clicking does trigger a
clickevent.However, after testing a newer version (Firefox 90), the
clickevent is no longer triggered on right-click, which indicates the issue has been resolved in Firefox.Test code: https://jsfiddle.net/r1cawjk7/
Because the 100ms delay in the code still causes the click event to propagate down. Reproduction method: Open the note map in the note ribbon, select a map node, then open the content menu. Long press 'Open Note in New Tab', and release the mouse when the right-click menu closes. At this point, the click event propagates down because the click event is triggered on mouse up. Therefore, the content menu is hidden on mouseup.