Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Open note and activate#1854

Merged
eliandoran merged 8 commits intodevelopfrom
open_new_tab
May 11, 2025
Merged

Open note and activate#1854
eliandoran merged 8 commits intodevelopfrom
open_new_tab

Conversation

@SiriusXT
Copy link
Copy Markdown
Member

@SiriusXT SiriusXT commented May 4, 2025

Added support for opening and activating a note in a new tab using Ctrl+Shift+click on notes in the launcher pane, note tree, or note images.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 4, 2025

Folder/File Previous size New size Difference
/upload/TriliumNextNotes-Server-1854-merge-linux-x64.tar.xz 69.28MB +69.28MB (+100.00%)
TOTAL +69.28MB

Copy link
Copy Markdown
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be feasible for you to write some Playwright tests for your functionality?

End-to-end tests go in apps/server-e2e. Basically, you would need three test cases, for each of your features (in tree, in images and in launcher).

@SiriusXT
Copy link
Copy Markdown
Member Author

SiriusXT commented May 5, 2025

Would it be feasible for you to write some Playwright tests for your functionality?

End-to-end tests go in apps/server-e2e. Basically, you would need three test cases, for each of your features (in tree, in images and in launcher).

I'm not familiar with end-to-end tests, and I tried writing tests for opening and activating notes from the launcher and the tree. However, in apps/server/spec/db, there's no note that contains an image. Do I need to create such a note and then push the database?

@eliandoran eliandoran added this to the v0.94.0 milestone May 9, 2025
@eliandoran eliandoran merged commit 5f27357 into develop May 11, 2025
11 checks passed
@eliandoran eliandoran deleted the open_new_tab branch May 11, 2025 21:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants