This repository was archived by the owner on Jun 24, 2025. It is now read-only.
fix(electron_context_menu): fix disabled search engine contex menu on readonly notes#1590
Merged
eliandoran merged 1 commit intodevelopfrom Apr 1, 2025
Merged
fix(electron_context_menu): fix disabled search engine contex menu on readonly notes#1590eliandoran merged 1 commit intodevelopfrom
eliandoran merged 1 commit intodevelopfrom
Conversation
…n readonly notes fixes #543
JYC333
approved these changes
Apr 1, 2025
eliandoran
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR aims to fixes bug described in TriliumNext/Trilium#5245 - it was caused by a wrong check in the "enabled" prop:
It was previously checking if
canPaste- which in this context does not make sense.Here it would only make sense to check for
hasText, which is already done hereNotes/src/public/app/menus/electron_context_menu.ts
Line 96 in aa418c4
just need to do a quick build and test properly, before I mark this as ready - will happen later today.
fixes TriliumNext/Trilium#5245