You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 9, 2025. It is now read-only.
@Alumniminium I apologize, I should have clarified this better. This feature has not been implemented into the main Notes branch yet. It still has to be reviewed and approved under this PR before this PR is applicable.
@Alumniminium I apologize, I should have clarified this better. This feature has not been implemented into the main Notes branch yet. It still has to be reviewed and approved under this PR before this PR is applicable.
Ah, I figured this was important because your PR targeted main and not initial-review so I figured MFA had been merged into the latest (or next) version. I'll keep an eye on the PR on Notes, if it doesn't get merged, I'll undo this merge and rebase it into initial-review.
Either way, no harm done. Thanks for writing the documentation for this feature!
@Alumniminium I apologize, I should have clarified this better. This feature has not been implemented into the main Notes branch yet. It still has to be reviewed and approved under this PR before this PR is applicable.
Ah, I figured this was important because your PR targeted main and not initial-review so I figured MFA had been merged into the latest (or next) version. I'll keep an eye on the PR on Notes, if it doesn't get merged, I'll undo this merge and rebase it into initial-review.
Either way, no harm done. Thanks for writing the documentation for this feature!
That's my bad. I didn't realize there was a branch for review. Good to know for the future!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs for Notes MFA pull request. Feature addition: Updated MFA