Merged
Conversation
Member
Author
|
Of course I'll change the submodule repo URL, this is temporarily set to our fork just to test if Travis can deal with submodules. This requires TrenchBoot/tpmlib#20 to work. |
|
This pull request introduces 1 alert when merging 745ffe1 into d8f0fc0 - view on LGTM.com new alerts:
|
dpsmith
approved these changes
Jul 27, 2020
andyhhp
reviewed
Jul 27, 2020
This makes it compatible with Linux's API. All usages were also fixed, except for pci_conf1_write() - it was using the new order previously, which was an error. Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
This fixes implicit function declaration for hosted builds due to memset() being used in the TPM code. Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
ce214ad to
1845550
Compare
rossphilipson
approved these changes
Aug 1, 2020
Collaborator
rossphilipson
left a comment
There was a problem hiding this comment.
Reviewed-by: Ross Philipson ross.philipson@oracle.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.