pci.c: rework PCI handling, do not use hardcoded MMIO base address#4
Merged
dpsmith merged 1 commit intoTrenchBoot:masterfrom Aug 22, 2019
Merged
pci.c: rework PCI handling, do not use hardcoded MMIO base address#4dpsmith merged 1 commit intoTrenchBoot:masterfrom
dpsmith merged 1 commit intoTrenchBoot:masterfrom
Conversation
andyhhp
approved these changes
Aug 22, 2019
Collaborator
andyhhp
left a comment
There was a problem hiding this comment.
The old PCI_MMIO_BASE() is clearly broken. This is definitely an improvement.
Reviewed-by: Andrew Cooper andrew.cooper3@citrix.com
Collaborator
|
Krystian please add Andy's RB then we can get this merged. |
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
e7f1ea5 to
5644191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com