🐛 Fix "uneditable" 0min checkins & allow checking in to a destination 0 min away#2322
Merged
MrKrisKrisu merged 1 commit intoTraewelling:developfrom Feb 7, 2024
Merged
🐛 Fix "uneditable" 0min checkins & allow checking in to a destination 0 min away#2322MrKrisKrisu merged 1 commit intoTraewelling:developfrom
MrKrisKrisu merged 1 commit intoTraewelling:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently not possible to edit a checkin where the arrival at the destination is the same time as the departure from the origin without changing the destination. You are forced to change the destination or to delete and recreate the checkin.
Before:
After:
I was wondering whether there are more issues related to these lovely 0 minute durations between stopovers and I found another issue here:
Trip view for start at stopover Obernahmer: it is possible to check in with destination Obernahmer Land or Lahmen Hasen.
Trip view for start at stopover Obernahmer Land: it is not possible to check in towards Lahmen Hasen.
With the fix applied 🐇
I didn't deduplicate the code because I kept using the stopover for the existing checkin edit case, and station + departure for the new trip case. I also don't use the planned arrival anymore inside getAlternativeDestinationsForCheckin since the remaining code determines the exact stopover after which every remaining stopover will pass.
I hope there are no cases where the condition never evaluates to true; or where the pair of (departure + stopover), or (departure + station) are not uniquely identifying exactly one stopover of a trip.