Skip to content

fix(tests): update correlation patch path after refactor#2758

Merged
muddlebee merged 1 commit into
Tracer-Cloud:mainfrom
cerencamkiran:fix/correlation-patch-paths
Jun 5, 2026
Merged

fix(tests): update correlation patch path after refactor#2758
muddlebee merged 1 commit into
Tracer-Cloud:mainfrom
cerencamkiran:fix/correlation-patch-paths

Conversation

@cerencamkiran

Copy link
Copy Markdown
Collaborator

Fixes failing pipeline tests after the correlation package move from app.correlation to app.agent.correlation.

The tests in tests/pipeline/test_runners_agent_class.py were still patching the old node_correlate_upstream import path, which caused:

AttributeError: module 'app' has no attribute 'correlation'

This PR updates the patch targets to match the new package location introduced by the correlation refactor.

Tested locally:

pytest tests/pipeline/test_runners_agent_class.py -v

Ekran görüntüsü 2026-06-05 163227

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Greptile code review

This repo uses Greptile for automated review. Before merge, aim for Confidence Score: 5/5 with zero unresolved review threads — see CONTRIBUTING.md.

Run a review — add a PR comment with:

@greptile review

Give it ~5-10 minutes (sometimes longer) for results, then fix feedback and re-trigger until you reach Confidence Score: 5/5.

Optional: automate with the greploop skill.

@greptile-apps

greptile-apps Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes three unittest.mock.patch targets in the pipeline test file that were still pointing at the old app.correlation.node import path after the correlation package was moved to app.agent.correlation.

  • All three patch(\"app.correlation.node.node_correlate_upstream\", ...) calls are updated to patch(\"app.agent.correlation.node.node_correlate_upstream\", ...), matching the refactored module layout.
  • The target function node_correlate_upstream is confirmed to exist at app/agent/correlation/node.py, so the new patch paths are valid and no test logic was changed.

Confidence Score: 5/5

Safe to merge — the change only updates mock patch targets to reflect an already-landed module move, with no logic changes.

All three patch paths now correctly point to app.agent.correlation.node.node_correlate_upstream, where the function is confirmed to exist. The change is mechanical, test-only, and fully consistent across every occurrence in the file.

No files require special attention.

Important Files Changed

Filename Overview
tests/pipeline/test_runners_agent_class.py Updates three patch() targets for node_correlate_upstream from the old app.correlation.node path to the correct app.agent.correlation.node path after the correlation package was moved; function exists at the new location and the fix is complete and consistent.

Reviews (1): Last reviewed commit: "fix(tests): update correlation patch pat..." | Re-trigger Greptile

@muddlebee muddlebee merged commit 247c771 into Tracer-Cloud:main Jun 5, 2026
15 checks passed
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🤖 CI passed. Linter didn't scream. Reviewer typed LGTM. @cerencamkiran, every machine in this pipeline just slow-clapped. 🖥️✨


👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants