fix(mcp): restore /mcp path in publicMcp base URL#2249
Merged
jordan-umusu merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
topher-lo
approved these changes
Mar 4, 2026
Contributor
There was a problem hiding this comment.
2 issues found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="deployments/helm/tracecat/templates/_helpers.tpl">
<violation number="1">
P1: Default `publicMcpUrl` drops the `/mcp` path, which can break MCP OAuth discovery and route resolution when `urls.publicMcp` is not explicitly set.</violation>
</file>
<file name="deployments/eks/modules/eks/helm.tf">
<violation number="1">
P1: publicMcp drops the /mcp suffix, so MCP endpoints will resolve under the root domain instead of /mcp. This reintroduces the broken OAuth discovery paths the PR is trying to fix. Keep /mcp in the public MCP base URL.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Restore the /mcp path in the public MCP base URL and fix ingress matching so OAuth discovery and protected-resource endpoints resolve under /mcp.
Written for commit 1214b7c. Summary will update on new commits.