feat(eks): scale MCP workloads and node group defaults#2214
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="deployments/eks/modules/eks/variables.tf">
<violation number="1" location="deployments/eks/modules/eks/variables.tf:78">
P3: Update the EKS README default deployment profile values to match the new node group defaults so operators don’t follow outdated sizing guidance.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
1to2in Terraform variables atdeployments/eks/variables.tfanddeployments/eks/modules/eks/variables.tf(variabletracecat_mcp_replicas).10/10/16viadeployments/eks/variables.tfanddeployments/eks/modules/eks/variables.tf(node_desired_size,node_min_size,node_max_size).3/3/6viadeployments/eks/variables.tfanddeployments/eks/modules/eks/variables.tf(spot_node_desired_size,spot_node_min_size,spot_node_max_size).deployments/eks/modules/eks/helm.tfto set MCP pod resource requests/limits to4000mCPU and4096Mimemory, and aligned the Helm chart defaultdeployments/helm/tracecat/values.yamlso MCP also showsreplicas: 2and the updated resource values.Testing
python -c "import yaml, pathlib; yaml.safe_load(pathlib.Path('deployments/helm/tracecat/values.yaml').read_text())"to validate the modified Helmvalues.yaml, which succeeded.git diff --checkto ensure no trailing whitespace/conflicts, which returned clean.terraform fmton modified Terraform files but theterraformCLI was not available in this environment, so formatting could not be validated here.Codex Task
Summary by cubic
Scaled the Tracecat MCP service by setting replicas to 2 and setting pod resources to 1000m CPU and 1024Mi memory. Increased EKS capacity defaults to 10/10/16 (on-demand) and 3/3/6 (spot), and updated the README default profile to match.
Written for commit f1eee89. Summary will update on new commits.