Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
publicMcpis set when TLS is terminated at ALB so OIDC callbacks work.Description
tracecat_mcp_enabledandtracecat_mcp_replicasto both the rootdeployments/eks/variables.tfand moduledeployments/eks/modules/eks/variables.tfand passed them through indeployments/eks/main.tf.deployments/eks/modules/eks/helm.tfto setmcp.enabled,mcp.replicas, and expliciturls.publicMcp, and added ALB split-ingress annotations for MCP (alb.ingress.kubernetes.io/group.orderandalb.ingress.kubernetes.io/healthcheck-path).virtualservice.yaml(deployments/helm/tracecat/templates/virtualservice.yaml) to render IstioVirtualServiceHTTP matches that route/mcp, OIDC discovery endpoints and auth routes (/.well-known/*,/authorize,/token,/register,/consent,/auth/callback) to the MCP service whenmcp.enabled=true.deployments/eks/README.md(how to enable viaTF_VAR_*), anddeployments/helm/README.md(values and VirtualService notes for MCP/OIDC).feat(deployments): add MCP support for EKS and Istio routing.Testing
git diff --checkand it succeeded with no whitespace errors. (passed)terraform fmt -recursive deployments/eksbut Terraform CLI is not available in this environment, so formatting could not be validated here. (not run)helm template ...to validate chart rendering withmcp.enabled=true, but Helm CLI is not available in this environment, so template rendering could not be validated here. (not run)git commit). (passed)Codex Task
Summary by cubic
Adds MCP support to EKS deployments and fixes routing so MCP and OIDC endpoints go to the MCP service under both ALB split-ingress and Istio. Also sets urls.publicMcp for proper OIDC callbacks when TLS terminates at ALB.
New Features
Bug Fixes
Written for commit d3e587a. Summary will update on new commits.