feat(workflow): surface while-loop progress in compact events and UI#2178
Merged
daryllimyt merged 12 commits intomainfrom Feb 27, 2026
Merged
feat(workflow): surface while-loop progress in compact events and UI#2178daryllimyt merged 12 commits intomainfrom
daryllimyt merged 12 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 20 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tracecat/dsl/scheduler.py">
<violation number="1" location="tracecat/dsl/scheduler.py:379">
P1: When `_handle_loop_end` is called with `is_skipping=True`, it falls through to `_handle_success_path` instead of propagating the skip to downstream tasks. This means tasks after the loop will execute even when the entire loop was skipped. The skip branch should mark all outgoing edges as unreachable (like `_handle_loop_start` does) and return early.</violation>
</file>
<file name="frontend/src/components/builder/events/events-workflow.tsx">
<violation number="1" location="frontend/src/components/builder/events/events-workflow.tsx:366">
P3: Size styling is missing for loop status icons. `getWorkflowEventIcon` is called without the `size-5` class, so loop rows render larger icons than other rows and can overflow the 20px container.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62b6cee150
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
jordan-umusu
requested changes
Feb 26, 2026
Collaborator
jordan-umusu
left a comment
There was a problem hiding this comment.
LGTM, just one fix
6573407 to
5122b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core.loop.start/core.loop.endno longer resolve toaction_result: nullin compact eventsloop_index(for_each):while_iterationwhile_continueloop_indexsemantics unchanged for looped child-workflow fan-inIteration N,continue/exit)Backend details
tracecat/dsl/workflow.py_noop_loop_action()now injects the action's own stream-aware result intoexec_context.ACTIONS[task.ref]before invoking noop loop activities, ensuring loop control payload is persistedtracecat/workflow/executions/schemas.pywhile_iterationandwhile_continuetoWorkflowExecutionEventCompacttracecat/workflow/executions/service.pyFrontend details
frontend/src/lib/event-history.tsfrontend/src/components/executions/event-history.tsxfrontend/src/components/builder/events/events-workflow.tsxfrontend/src/components/events/workflow-events-list.tsxValidation
uv run ruff check tracecat/dsl/workflow.py tracecat/workflow/executions/schemas.py tracecat/workflow/executions/service.py tests/unit/test_workflow_executions.pyuv run basedpyright tracecat/dsl/workflow.py tracecat/workflow/executions/schemas.py tracecat/workflow/executions/service.py tests/unit/test_workflow_executions.pyuv run pytest tests/unit/test_workflow_executions.py -qpnpm -C frontend run typecheckSummary by cubic
Adds do-while loop control flow (core.loop.start/end) and shows while-loop progress in compact events and the UI. Enforces a 2048-iteration cap; for_each behavior stays the same.
New Features
Bug Fixes
Written for commit 5122b6a. Summary will update on new commits.