fix: show Workflow sync as gated in org settings#2166
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 542a6ea425
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
542a6ea to
fd1f998
Compare
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tracecat/registry/sync/tarball.py">
<violation number="1" location="tracecat/registry/sync/tarball.py:222">
P2: Offload the site-packages size calculation to a worker thread so the async event loop isn’t blocked by large filesystem traversal.
(Based on your team's feedback about offloading potentially slow synchronous file I/O in async functions.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
fd1f998 to
32bac65
Compare
|
@cubic-dev-ai rereview |
|
@codex rereview |
@daryllimyt I have started the AI code review. It will take a few minutes to complete. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Workflow syncitem visible in the organization settings sidebar even whengit_syncis disabledWorkflow syncwhengit_syncis unavailable, matching gated behavior likeGit repository/organization/vcsnot-found redirect with an entitlement-gated empty state and upgrade CTATesting
pnpm -C frontend exec biome check src/app/organization/vcs/page.tsx src/components/sidebar/organization-sidebar.tsxuv run ruff check .Summary by cubic
Keep Workflow sync visible in org settings and gate the page with an upgrade CTA when git_sync is unavailable. Revert the builtin registry tarball build to use the venv-from-source path and add uncompressed size metrics.
Bug Fixes
Refactors
Written for commit 32bac65. Summary will update on new commits.