fix(dsl): resolve VARS expressions in agent action args#2074
Merged
daryllimyt merged 5 commits intomainfrom Feb 27, 2026
Merged
fix(dsl): resolve VARS expressions in agent action args#2074daryllimyt merged 5 commits intomainfrom
daryllimyt merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="tests/unit/test_build_agent_args.py">
<violation number="1" location="tests/unit/test_build_agent_args.py:69">
P2: Tests under `tests/unit` are expected to run as integration-style tests without mocks. These new tests patch `get_workspace_variables` with `AsyncMock`, which conflicts with the project testing guideline and risks diverging from production behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 451d98e8d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
4c19758 to
97b0ad0
Compare
daryllimyt
requested changes
Feb 11, 2026
e735ce9 to
5d116d9
Compare
daryllimyt
requested changes
Feb 13, 2026
Contributor
daryllimyt
left a comment
There was a problem hiding this comment.
- move resolve agent context activity into build_preset_agent_args_activity
- make build_preset_agent_args_activity async
This comment has been minimized.
This comment has been minimized.
c99e0ae to
06fa6d9
Compare
daryllimyt
requested changes
Feb 19, 2026
06fa6d9 to
2360efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes VARS resolution in agent and preset agent action args with correct environment overrides. Environment is resolved inside the build activities (templates supported), and expression evaluation is offloaded to threads to avoid event-loop blocking.
Written for commit 2360efd. Summary will update on new commits.