Add option for mayors to grant freeflight in their towns via new /t toggle flight command.#91
Conversation
LlmDl
left a comment
There was a problem hiding this comment.
There are a lot of unneeded diffs that need to be undone before I will review this and potentially merge it into the plugin.
undo diffs made by ide
Undo difs made by ide
Undo difs made by ide
|
Sorry didnt realize my IDE auto made a bunch of formatting changes, have undone them |
LlmDl
left a comment
There was a problem hiding this comment.
I'm not entirely on board with how you've handled adding in your command before the pre-existing command is handled. It would be nicer if your command had a togglePublicFlight subcommand, or something to differentiate between mayors and admins doing the toggling of flight.
src/main/java/com/gmail/llmdlio/townyflight/TownyFlightCommand.java
Outdated
Show resolved
Hide resolved
|
What I could do is add a sub command to the towny plugin with /t toggle flight or something similar |
|
Also I could be wrong but just to make sure when a town has the allow flight metadata the user still needs to have permissions to use /tfly correct |
Get rid of unneeded diff hopefully
# Conflicts: # src/main/java/com/gmail/llmdlio/townyflight/TownyFlightCommand.java
Fixing Diffs again
Fix diffs again
forgot default and fix diff
had wrong permission node
|
I cant get that one diff to go away at the end of plugin.yml |
Accidentally had wrong class name for registering cmd
Renaming for conventional naming
…mandAddon.java Renaming for conventional naming
Permission Renaming
permission renaming
LlmDl
left a comment
There was a problem hiding this comment.
Just the diff to clear up, I'd also appreciate you confirming that you've tested this iteration yourself.
|
I have not fully tested it but today I will compile it and test it |
|
I just went to change the other thing, and I can tell you it won't compile at all. Please get it to a point that it is ready before requesting a review next time. |
Change to return false > true
Extra ; typo
|
I have tested it and did not come across any issues as well as everything working as intended |
|
Any update on this? |
src/main/java/com/gmail/llmdlio/townyflight/integrations/TownToggleFlightCommandAddon.java
Outdated
Show resolved
Hide resolved
…oggleFlightCommandAddon.java Co-authored-by: LlmDl <LlmDlio@gmail.com>
|
Compiled and tested |
To use:
Mayors must be given
townyflight.command.town.toggle.flightin the townyperms.yml's mayor section.Made it so mayors of towns can toggle public flight within their town with /tfly town toggleflight
added a new permission so people with
townyflight.command.tfly.town.other
can toggle the flight of any town while just townyflight.command.tfly.town can only toggle their towns