Skip to content

Remove special siege outcome effects#986

Merged
Goosius1 merged 1 commit intoTownyAdvanced:masterfrom
Goosius1:remove_special_siege_outcomes
Oct 3, 2025
Merged

Remove special siege outcome effects#986
Goosius1 merged 1 commit intoTownyAdvanced:masterfrom
Goosius1:remove_special_siege_outcomes

Conversation

@Goosius1
Copy link
Copy Markdown
Collaborator

@Goosius1 Goosius1 commented Oct 2, 2025

Description:

  • Current code has the feature of "Special Siege Outcomes", such as splitting the warchest amounts between attacker/defender, reducing the plunder amount, and demoralizing a defeated occupier in a revolt siege.
  • On inspection, the demoralization feature doesn't appear to be connected up.
  • Also on reflection, these special outcomes probably add a bit too much complexity to the system to have any net benefit.
  • So this PR removes the special siege outcomes feature.
  • In addition, the PR adds a new outcome-level, which doesn't have any functional effect, but has gotta be pretty cool when it gets declared automatically in the general chat: "CRUSHING" victories.

New Nodes/Commands/ConfigOptions:

N/A


Relevant Issue ticket:

N/A


  • [ x ] I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

@Goosius1 Goosius1 self-assigned this Oct 2, 2025
- Also added a new siege outcome level - crushing
@Goosius1 Goosius1 force-pushed the remove_special_siege_outcomes branch from b0baf7f to 4dad19b Compare October 2, 2025 13:57
@Goosius1 Goosius1 added this to the 3.0.0 milestone Oct 2, 2025
@Goosius1 Goosius1 merged commit 20b7d32 into TownyAdvanced:master Oct 3, 2025
@Goosius1 Goosius1 deleted the remove_special_siege_outcomes branch October 3, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants