Description:

There has been an existing bug in SiegeWar that has gone unnoticed for quite a long time (about a year). The bug allows players to capture the banner at any height below the banner, completely ignoring the war.distances.banner_control_session_radius_blocks config setting. This PR aims to solve this bug by simplifying the vertical distance check and fixing the issue.

The Bug

The issue is with how the vertical distance check between the player and flag is calculated. Currently, the calculation for the vertical distance is calculated as follows:

    //Check vertical distance
		
    double yDistance = Math.sqrt(MathUtil.sqr(location1.getY()) - MathUtil.sqr(location2.getY()));
    if (yDistance > maxAllowedDistance)
       return false;

    return true;

If the player is below the flag, then this difference in their Y is negative producing a square root that is always NaN. When compared to any maxAllowedDistance (always false), the return is true allowing the check to incorrectly pass.

New Nodes/Commands/ConfigOptions:

Relevant Issue ticket:

• I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.