Conversation
LlmDl
left a comment
There was a problem hiding this comment.
I'd also like you to confirm that this doesn't require any changes to the config.yml file in the resources folder.
From the looks of it, it appears that the new setting only needs to know which line the timer is on.
| private static Material beaconWireFrameMaterial = null; | ||
| /** Set of EditableMaterials which can be built/destroyed in attacked cells. */ | ||
| private static Set<Material> editableMaterialsInWarZone = null; | ||
| /** Index value for the timer string in the hologram (if enabled) */ |
There was a problem hiding this comment.
This should be more descriptive and make mention that it is the line on the hologram where the time remaining will appear. The variable name could also be clearer.
There was a problem hiding this comment.
config.yml does not need any changes, the created variable is just a helper to cache the line index (instead of having to find where the timer is located whenever creating/updating a hologram).
Updated comment:
Index to know which hologram line contains the timer string (not shown/used in config.yml)
Is hologramTimerLineIndex a better variable name? idk what else to label it.
|
Yeah that's a clearer name
…On Wed, Feb 11, 2026, 11:33 AM Fer2G ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/java/io/github/townyadvanced/flagwar/config/FlagWarConfig.java
<#421 (comment)>
:
> @@ -59,6 +59,8 @@ private FlagWarConfig() {
private static Material beaconWireFrameMaterial = null;
/** Set of EditableMaterials which can be built/destroyed in attacked cells. */
private static Set<Material> editableMaterialsInWarZone = null;
+ /** Index value for the timer string in the hologram (if enabled) */
config.yml does not need any changes, the created variable is just a
helper to cache the line index (instead of having to *find* where the
timer is located whenever creating/updating a hologram).
Updated comment:
Index to know which hologram line contains the timer string (not
shown/used in config.yml)
Is hologramTimerLineIndex a better variable name? idk what else to label
it.
—
Reply to this email directly, view it on GitHub
<#421 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGWZDDLDKTB5SVXE5EUDT34LNRUZAVCNFSM6AAAAACUWHZUUCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOOBWGA3TOMZYHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Brief Description:
Fixes for:
Relevant FlagWar Issue tickets:
resolves #420
By making this pull request, I represent that I have read and agree to release my own changes that I
have submitted under the terms of the accompanying license (Apache-2.0). I guarantee that these
changes are mine and are not encumbered by any other license or restriction to the best of my
knowledge.