Merged
Conversation
There are some instances where spelling is regional. These have been ignored.
Sending these error messages through TownyMessaging may slightly obfuscate the source - and we're fully capable of passing the exception to the JUL logger.
Explicitly catch InvalidConfigurationException, rather than the general all-encompassing Exception class. Also rolls the stacktrace into the JUL logger. The Towny null check in checkTowny() was removed, as it *should* never evaluate to null. The translation key has also been removed.
LlmDl
approved these changes
Jan 27, 2026
| return true; | ||
| } | ||
|
|
||
| @SuppressWarnings("unused") |
Member
There was a problem hiding this comment.
Does this show as unused in your IDE?
Member
Author
There was a problem hiding this comment.
It flags it for the args parameter, not so much for the method itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Description:
Several small changes that focus on cleaning up a bit.
Changes:
FlagWarCustomListenerRelevant FlagWar Issue tickets:
N/A
By making this pull request, I represent that I have read and agree to release my own changes that I
have submitted under the terms of the accompanying license (Apache-2.0). I guarantee that these
changes are mine and are not encumbered by any other license or restriction to the best of my
knowledge.