(Experimental) Add DecentHolograms Support#386
Merged
Conversation
LlmDl
requested changes
Nov 11, 2024
Member
LlmDl
left a comment
There was a problem hiding this comment.
Looks good to me aside from the typos that's probably going to keep it from working.
src/main/java/io/github/townyadvanced/flagwar/objects/CellUnderAttack.java
Show resolved
Hide resolved
src/main/java/io/github/townyadvanced/flagwar/objects/CellUnderAttack.java
Outdated
Show resolved
Hide resolved
Member
Author
|
D'oh! Thanks for pointing that out. |
LlmDl
approved these changes
Nov 11, 2024
Member
LlmDl
left a comment
There was a problem hiding this comment.
I'm good with this, once we hear back that it does work.
1 task
d30aaae to
81b72dc
Compare
- New Classes:
- HologramUtil
- Holds ~90% of the remaining hologram logic.
- Most calls have been inlined or ported over here.
- FormatUtil
- Relocates time formatting to clean up the CellUnderAttack class.
- Other formatting methods may follow later.
bc663cc to
05320df
Compare
- Fix "instancing" in a static util class. - Remove double draw call - Simplify variable names and Javadocs - Some debug messages.
LlmDl
approved these changes
Jan 24, 2026
LlmDl
requested changes
Jan 24, 2026
- Builds against Java 17, and Paper 1.19.4 _You **really** should be on a newer version, though._ - Re-adds JDK 17 to the actions workflow - Bumps minimum Towny version in FlagWar.java
LlmDl
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Having some copious free time at work, I took the liberty of updating the PR in a different direction. As before, this PR attempts to add support for DecentHolograms, but diverges to remove HolographicDisplays support.
Bear in mind that while this builds, it absolutely needs tested. I would like to continue to flesh it out, so a test build will be published to the discord after I'm happy with the state of it. If no issues are reported, and it passes re-inspection, this should be merged.
Changes
Relevant FlagWar Issue tickets:
Fixes / Resolves
The following Issues should be resolved by the PR:
Supercedes
The following PRs are wrapped in as part of the housekeeping phase:
** PENDING ** Previous tests are unreliable for a current build.
By making this pull request, I represent that I have read and agree to release my own changes that I
have submitted under the terms of the accompanying license (Apache-2.0). I guarantee that these
changes are mine and are not encumbered by any other license or restriction to the best of my
knowledge.