raspberryPi-*: Increase malloc pool to 64 MiB (+env)#35
Merged
samueldr merged 1 commit intoTow-Boot:developmentfrom Jun 26, 2021
Merged
raspberryPi-*: Increase malloc pool to 64 MiB (+env)#35samueldr merged 1 commit intoTow-Boot:developmentfrom
samueldr merged 1 commit intoTow-Boot:developmentfrom
Conversation
Contributor
Author
|
Found the reason.
Basically the Raspberry Pi family of hardware uses a tiny amount of space for malloc (4MiB). This probably is fine and by design due to the considerations listed beforehand. The early models with 256MiB of RAM, in which a chunk is reserved for the videocore chip. We probably can and should look into fulfilling the TODO, and conditionally apply different sizes depending on the target Raspberry Pi. Though we might also just want to increase it outright? TODO
|
1e12b40 to
1add448
Compare
This fixes the issue where the bitmap logo couldn't be used, as `malloc()` would fail to allocate ~9MiB. After all *that* doesn't fit in ~4MiB!
1add448 to
e917694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the logo wouldn't show on the Raspberry Pi family of hardware.
This is not really an upstreamable change. Really this probably shouldn't be hardcoded per platform in header files, but rather some
Kconfigoption?