Add support for FriendlyELEC NanoPi M1#257
Conversation
|
Just in case, display issue is not specific to NanoPi M1, and also reproducible on OrangePi H3. |
samueldr
left a comment
There was a problem hiding this comment.
Hi!
Thanks for the contribution!
Looks mostly right. Things I shared here are more nits than outright issues, but should be fixed.
If you can, please amend and force push a new single commit; if you can't, no worries, I can handle that for the merge.
| { lib, ... }: | ||
|
|
There was a problem hiding this comment.
(See follow-up; since lib won't be needed, we can drop it.)
That would be helpful, thanks in advance. One more question: is it okay to submit two other very similar boards that I don't have on hands? I talking about NanoPi M1 Plus and Libre Computer ALL-H3-CC H3. Chances of anything going wrong with these two is very low as I understand. |
|
Forgot to mention that I used lib.mkDefault because I intended to submit M1 Plus too: |
It is required for the builds to have been verified to work, so you can submit it a as a draft PR by clearly stating that they have not been tested and testing that testing by owners of the board is welcome. Even though I agree that they are very likely to work, considering it's Allwinner. |
Understood. What to do with lib.mkDefault here then? Will you remove it or keep it? |
|
Force-pushsed:
|
Support was tested only with this tree.
At least Debian 12 armhf boot fine, but in my case - only in headless mode, which could be related to my display (Dell UP3017) resolution 2560x1600. However, while I getting black screen when kernel switch from framebuffer, video output before this moment (including video output in Tow-Boot and GRUB2) works without issues. Another observation is that USB support is a bit flaky - Tow-Boot goes into boot loop if Belkin USB-C 3.1 Express Dock HD or even Satechi Type-C Card Reader (expose two block devices) is connected, but this isn't likely to cause any issues in real-world scenarios for this board (signage, thin client, print server, pihole, etc.)
Anyway, with 2022.07 test branches situation was even worse (I wasn't able to even get to Tow-Boot's menu as I remember) so we still have a nice progress here.