Skip to content

odroid-N2: Add support for XT25Q64D#149

Merged
samueldr merged 1 commit intoTow-Boot:developmentfrom
ulrikstrid:ulrikstrid/odroid-N2-plus
Jun 10, 2022
Merged

odroid-N2: Add support for XT25Q64D#149
samueldr merged 1 commit intoTow-Boot:developmentfrom
ulrikstrid:ulrikstrid/odroid-N2-plus

Conversation

@ulrikstrid
Copy link
Contributor

This adds a build for the odroid N2+ computer. Also adds support for the XTX SPI XT25Q64D

Copy link
Contributor

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi!

Thank you for the contribution!


We can do more simpler. The N2 configuration is already used for N2+.

In fact, your problem is not plus vs. non-plussed N2, but that some of the batches (new ones?) apparently are using a new yet-unsupported SPI Flash.

So, really, you can condense this into only:

Add support for XTX SPI XT25Q64D

And apply it to the existing N2 configuration.

Adding a note here that this is desirable. When possible, board configurations should be coalesced into a single one.

@ulrikstrid ulrikstrid force-pushed the ulrikstrid/odroid-N2-plus branch from 84c875a to f27b62e Compare April 26, 2022 19:54
Signed-off-by: Ulrik Strid <ulrik.strid@outlook.com>
@ulrikstrid ulrikstrid force-pushed the ulrikstrid/odroid-N2-plus branch from f27b62e to e99c569 Compare April 26, 2022 20:02
@samueldr samueldr self-requested a review April 26, 2022 20:02
@samueldr
Copy link
Contributor

samueldr commented Apr 26, 2022

I'll need to build it for verification, but I don't have the hardware to test. The changes look okay. You probably want to rename the PR something like "odroid-N2: Add support for XT25Q64D"

I assume that you have now been able to successfully flash to SPI, and start your N2+ from SPI, right?

@ulrikstrid
Copy link
Contributor Author

I have not tested it with the new changes, but it builds, I can try it tomorrow.
The initial state of this PR flashes and I have managed to boot NixOS on top

@ulrikstrid ulrikstrid changed the title Add odroid-N2-plus odroid-N2: Add support for XT25Q64D Apr 26, 2022
@ulrikstrid
Copy link
Contributor Author

Note that the patch will not apply cleanly in upstream u-boot since they don't have the first patch.

@samueldr
Copy link
Contributor

Note that the patch will not apply cleanly in upstream u-boot since they don't have the first patch.

Either you'll have submitted something to upstream, or we rebase things ourselves, so it's not a big deal. Thanks for the heads-up.

@ulrikstrid
Copy link
Contributor Author

@samueldr I can confirm that I can flash the SPI and boot into a OS with the current state of this PR

@samueldr samueldr changed the base branch from released to development April 28, 2022 16:09
@samueldr samueldr added this to the 2022.07-005 milestone Jun 2, 2022
@samueldr samueldr added the 4. type: fix Not an enhancement, not a bugfix label Jun 2, 2022
@samueldr samueldr changed the base branch from development to released June 10, 2022 21:49
@samueldr samueldr changed the base branch from released to development June 10, 2022 21:49
@samueldr
Copy link
Contributor

(Changed the base branch to force a refresh of the PR... and yesterday I though the "refresh commits" option in SourceForge was weird...)

@samueldr samueldr merged commit 9eceb2a into Tow-Boot:development Jun 10, 2022
@samueldr
Copy link
Contributor

Thank you!

@ulrikstrid ulrikstrid deleted the ulrikstrid/odroid-N2-plus branch June 11, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. type: fix Not an enhancement, not a bugfix

Development

Successfully merging this pull request may close these issues.

2 participants