This repository was archived by the owner on May 5, 2023. It is now read-only.
fix: make opts.host work again#96
Merged
Merged
Conversation
Collaborator
|
It was deprecated at 6.1 and definetively removed at 6.2 so maybe just lock your version to 6.1? |
Contributor
Author
|
Breaking changes like that are usually included in a major version release, so I think it's better to patch v6 and release the current behavior as v7. |
Collaborator
|
makes sense; not sure why tests are failing |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95
I'm not sure if it was intentional to completely remove
hostsupport at some point or or not, but since this was a breaking change introduced in a minor release, I want to make it work again. I inferred that you hostname should be used instead of host so I markedhostas deprecated; please correct me if I'm wrong. I'm not personally attached tohostso I think it's fine to remove it in a major release 😄.