Merged
Conversation
Fixed broken code example
TobiasWrigstad
commented
Apr 23, 2025
* Tagged a bunch of things as TODO * Updated some parts according to discussions with Faster CPython team
mjp41
reviewed
Apr 25, 2025
Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com>
xFrednet
reviewed
Apr 29, 2025
TobiasWrigstad
commented
Apr 29, 2025
| PEP: 9999 | ||
| Title: Deep Immutability in Python | ||
| Author: Matthew Johnson <matjoh@microsoft.com>, Matthew Parkinson <mattpark@microsoft.com>, Sylvan Clebsch <sylvan.clebsch@microsoft.com>, Fridtjof Peer Stoldt <fridtjof.stoldt@it.uu.se>, Tobias Wrigstad <tobias.wrigstad@it.uu.se> | ||
| Sponsor: TBD |
Owner
Author
There was a problem hiding this comment.
Who should be our sponsor? Does that happen now or later?
| Title: Deep Immutability in Python | ||
| Author: Matthew Johnson <matjoh@microsoft.com>, Matthew Parkinson <mattpark@microsoft.com>, Sylvan Clebsch <sylvan.clebsch@microsoft.com>, Fridtjof Peer Stoldt <fridtjof.stoldt@it.uu.se>, Tobias Wrigstad <tobias.wrigstad@it.uu.se> | ||
| Sponsor: TBD | ||
| Discussions-To: TBD |
Owner
Author
There was a problem hiding this comment.
Do we know how to open a discussion on discord?
TobiasWrigstad
commented
Apr 29, 2025
TobiasWrigstad
commented
Apr 29, 2025
TobiasWrigstad
commented
Apr 29, 2025
TobiasWrigstad
commented
Apr 30, 2025
mjp41
reviewed
May 1, 2025
matajoh
reviewed
May 1, 2025
Collaborator
matajoh
left a comment
There was a problem hiding this comment.
I've gone through and made some updates based on implementation details
pep-9999.rst
Outdated
| data and uses the built-in functions of these types to modify the data. | ||
|
|
||
| To make its instances freezable, types using C extensions must | ||
| register themselves using ``register_freezable(type)``. To |
Collaborator
There was a problem hiding this comment.
Here is some sample code you could potentially include:
PyObject *register_freezable = _PyImport_GetModuleAttrString("immutable", "register_freezable");
if(register_freezable != NULL)
{
PyObject* result = PyObject_CallOneArg(register_freezable, (PyObject *)st->Element_Type);
if(result == NULL){
goto error;
}
Py_DECREF(register_freezable);
}Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com>
xFrednet
reviewed
May 6, 2025
Collaborator
xFrednet
left a comment
There was a problem hiding this comment.
Very good changes, I mainly have some nits and thinks I was unsure about when reading
Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.