Skip to content

Added wrappers for os.statvfs() and os.path.ismount()#162

Merged
Tinche merged 3 commits intoTinche:mainfrom
mdevaev:main
Aug 8, 2023
Merged

Added wrappers for os.statvfs() and os.path.ismount()#162
Tinche merged 3 commits intoTinche:mainfrom
mdevaev:main

Conversation

@mdevaev
Copy link
Contributor

@mdevaev mdevaev commented Mar 16, 2023

Subj. And if it doesn't bother you, I would appreciate it if you would release a minor release with this change, I need it for the upstream of my distro.

@Tinche
Copy link
Owner

Tinche commented Mar 20, 2023

Great, can you add a few tests too?

@Tinche
Copy link
Owner

Tinche commented Mar 20, 2023

And a changelog entry.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (2e40fc4) 90.98% compared to head (4ad14b0) 91.04%.
Report is 11 commits behind head on main.

❗ Current head 4ad14b0 differs from pull request most recent head 2e945ba. Consider uploading reports for the commit 2e945ba to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   90.98%   91.04%   +0.05%     
==========================================
  Files          10       10              
  Lines         344      346       +2     
==========================================
+ Hits          313      315       +2     
  Misses         31       31
Files Changed Coverage Δ
src/aiofiles/os.py 100.00% <100.00%> (ø)
src/aiofiles/ospath.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdevaev
Copy link
Contributor Author

mdevaev commented Mar 20, 2023

Great, can you add a few tests too?

Sure. Pushed.

@Tinche
Copy link
Owner

Tinche commented Jul 6, 2023

@mdevaev Great, sorry for the delay. We just need a small doc update so folks know it was added in this version (so, the Changelog section) and so folks know it exists (around

aiofiles/README.md

Line 94 in 564b11e

- `stat`
). And I push the merge button ;)

@mdevaev
Copy link
Contributor Author

mdevaev commented Aug 8, 2023

@Tinche It's done, please take a look. I've also rebased it and resolved conflicts.

@Tinche
Copy link
Owner

Tinche commented Aug 8, 2023

Thanks!

@Tinche Tinche merged commit ec8cc1e into Tinche:main Aug 8, 2023
@catboxanon catboxanon mentioned this pull request Aug 9, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdevaev @Tinche @codecov-commenter