Merged
Conversation
danthedaniel
commented
Dec 15, 2024
creesch
reviewed
Dec 15, 2024
Collaborator
creesch
left a comment
There was a problem hiding this comment.
One actually remark on the escapeHtml function but other than that it seems good to me.
dd07fe5 to
6620979
Compare
* Fixed indentation for util.js to be consistently 4 spaces * Removed trailing whitespace * Removed carriage returns (\r\n -> \n)
Member
Author
|
If it's okay with you, I've added a couple small extra commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One small non-type change:
String.replaceAll()was a ES2021 feature, so I replaced it withString.replace()using a global regex.