Conversation
b168323 to
3bdd4a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had always found it a bit confusing how the status UI works. The "connected" / "disconnected" bit is for the websocket connection, an abstraction that the user isn't aware of.
Now the status text works like this:
Disconnected from Minecraft- (red) If the web UI can't talk to the modJoin a server to chat- (white) If not in a worldError: See browser console- (orange) If there is a websocket error$server_name- (white + color codes) When connected. Uses JetBrains Mono font to roughly match the server name display that would show in the server list in game.We no longer display the connection status and the server/world name. Just one or the other.
I also now clear the chat history and player list when disconnected from a server.
I increased the height of the status element when not in mobile view to match the height of the input area for visual alignment purposes.