Add Tenor feature flag through selected build type#4
Merged
ThomazFB merged 4 commits intoissue/11456-add-tenor-supportfrom Apr 3, 2020
Merged
Conversation
planarvoid
approved these changes
Apr 3, 2020
planarvoid
left a comment
There was a problem hiding this comment.
Looks great, thanks for the change 👍
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request makes possible to enable or disable the Tenor GIF picker availability accordingly to the selected WordPress build type. This change adds to the issue 11456.
The solution proposes the following implementation:
The
BuildConfignow receive the declaration of the booleanTENOR_AVAILABLEfield directly from thebuild.gradle.The button availability to select the Tenor GIF picker follows the
TENOR_AVAILABLEvalue, if the value is false, the button doesn't get configured and should never appear on the screen.The
TENOR_AVAILABLEis set astruefor the Wasabi and Zalpha builds andfalsefor the Vanilla build.Testing from the Post Editor
with Wasabi and Zalpha build
Switch to classic editorChoose from Tenoroption is availableselection,previewandaddare all working as expectedwith Vanilla build
Switch to classic editorChoose from Tenoroption isn't thereTesting from the Media Browser
with Wasabi and Zalpha build
Choose from Tenoroption is availableselection,previewandaddare all working as expectedwith Vanilla build
Choose from Tenoroption isn't therePR submission checklist
RELEASE-NOTES.txtif necessary.