Replace UI and internal Giphy references#3
Replace UI and internal Giphy references#3ThomazFB merged 7 commits intoissue/11456-add-tenor-supportfrom
Conversation
planarvoid
left a comment
There was a problem hiding this comment.
Overall looks pretty great! I have one comment about the translations but that should be fairly simple to change. Thanks for all the changes 👍
| <string name="stats_no_data_for_period">Keine Daten für diesen Zeitraum</string> | ||
| <string name="preference_strip_image_location">Positionsangabe von Medien entfernen</string> | ||
| <string name="stats_cannot_be_started">Wir können die Statistiken momentan nicht öffnen. Bitte versuche es später erneut</string> | ||
| <string name="giphy_powered_by_giphy">Bereitgestellt von GIPHY</string> |
There was a problem hiding this comment.
Maybe I didn't mention this explicitly. We shouldn't change any of the translation files. It should all go through the translation service. You should just change the names of the string items in the basic strings.xml (and you can also delete the translations of the original strings). I think (I'm not sure here) they'll get overriden by the service result anyway.
There was a problem hiding this comment.
Thanks for the feedback! I just deleted all translation strings as suggested and left the renaming and the Tenor replacement only at the original strings.xml file, would be fine that way? Here's the commit: 8eabca9 . Thanks!
planarvoid
left a comment
There was a problem hiding this comment.
Thanks for the changes! It all looks great :-). I'll leave the final round of stress-testing for the final PR 👍
Summary
This Pull Request brings renaming for all Giphy references inside package, classes, documentation and UI strings. Giving sequence to the issue 11456.
Here's the change log:
Every UI string with
Giphyinformation was replaced withTenor.The
giphypackages insideuiandviewmodelwere both renamed to onlygif.All classes with the
Giphynaming convention were renamed to onlyGifto better fit the agnostic gif provider implementation strategy.All comments and documentation with references to
Giphyor the Giphy SDK were readapted to better fit theGifProviderstructure.Removed the Giphy SDK reference at maven repository in
build.gradleTesting
Before testing
wp.tenor.api_keyas the value inside yourgradle.propertiesTesting from the Post Editor
Switch to classic editorChoose from Tenoroptionselection,previewandaddare all working as expectedTesting from the Media Browser
Choose from Tenoroptionselection,previewandaddare all working as expectedPR submission checklist
RELEASE-NOTES.txtif necessary.