fix: show all models in model check dialog instead of only enabled ones #953

Dw9 · 2025-09-30T06:26:24Z

Problem

When validating API key in provider settings, the model check dialog shows "no available models"
even though models were successfully fetched from the provider API.

Root Cause

The model check dialog was using settingsStore.enabledModels which only contains models that have
been manually enabled by users. Newly fetched models have enabled: false by default.

Solution

Changed ModelCheckDialog.vue to use settingsStore.allProviderModels instead of enabledModels,
so all fetched models (both enabled and disabled) are shown in the dialog.

Summary by CodeRabbit

New Features
- Model selection dialog now shows all models available from the chosen provider (not limited to previously enabled models), enabling broader discovery.
- Makes it easier to compare and validate model availability per provider without pre-enabling models, streamlining setup and evaluation.

coderabbitai · 2025-09-30T06:26:31Z

Walkthrough

The dialog’s model list source is changed to use allProviderModels[providerId] instead of enabledModels[providerId]. The inline comment was updated to state that all models are displayed. No exported/public interfaces are altered.

Changes

Cohort / File(s)	Summary of changes
Renderer settings UI `src/renderer/src/components/settings/ModelCheckDialog.vue`	Replace usage of `enabledModels[providerId]` with `allProviderModels[providerId]` to display all provider models; update the associated inline comment to reflect that all models are shown.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant Dialog as ModelCheckDialog.vue
  participant Store as Settings Store

  User->>Dialog: Open "Model Check" dialog
  Dialog->>Store: Request models for providerId (allProviderModels[providerId])
  Note over Dialog,Store #DDEBF7: Previously used enabledModels[providerId]
  Store-->>Dialog: Return full list of provider models
  Dialog-->>User: Render list of all models

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: disable automatic model enabling for better UX #734 — Changes renderer logic around enabled vs all provider models; complements this change by adjusting auto-enable/UI handling.
fix issue 622 #631 — Touches model-check UI/flow and provider/model handling, related to switching the dialog to use all provider models.

Poem

A rabbit hops through code at night,
Swapping filters for broader sight.
Every model now in view,
Hooray for choices, old and new.
Thump, thump—approve with fluffy might! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly and concisely describes the primary change of the pull request, specifying that the fix is to display all models in the model check dialog rather than only the enabled ones, which directly reflects the implemented code update.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a988e0d and f3c6223.

📒 Files selected for processing (1)

src/renderer/src/components/settings/ModelCheckDialog.vue (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/renderer/src/components/settings/ModelCheckDialog.vue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

Public repositories are always opted into early access features.
You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/renderer/src/components/settings/ModelCheckDialog.vue (1)
1-1: Fix Prettier formatting issue.

The pipeline indicates a formatting check failure. Run prettier --write on this file to resolve the code style issue.
#!/bin/bash
# Fix Prettier formatting
prettier --write src/renderer/src/components/settings/ModelCheckDialog.vue

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce1f1fd and a988e0d.

📒 Files selected for processing (1)

src/renderer/src/components/settings/ModelCheckDialog.vue (1 hunks)

🧰 Additional context used

📓 Path-based instructions (15)

src/renderer/src/**/*

📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/src/**/*.vue

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

Use scoped styles to prevent CSS conflicts between components

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/**/*.{vue,ts}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/**/*.{ts,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Use Pinia for frontend state management (do not introduce alternative state libraries)

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use English for all logs and comments

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Enable and adhere to strict TypeScript typing (avoid implicit any, prefer precise types)

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/{src,shell,floating}/**/*.vue

📄 CodeRabbit inference engine (CLAUDE.md)

src/renderer/{src,shell,floating}/**/*.vue: Use Vue 3 Composition API for all components
All user-facing strings must use i18n keys via vue-i18n (no hard-coded UI strings)
Use Tailwind CSS utilities and ensure styles are scoped in Vue components

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/src/components/**/*

📄 CodeRabbit inference engine (CLAUDE.md)

Organize UI components by feature within src/renderer/src/

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/src/**

📄 CodeRabbit inference engine (AGENTS.md)

Put application code for the Vue app under src/renderer/src (components, stores, views, i18n, lib)

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/src/**/*.{vue,ts}

📄 CodeRabbit inference engine (AGENTS.md)

All user-facing strings in the renderer must use vue-i18n keys defined in src/renderer/src/i18n

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

**/*.{js,jsx,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Apply Prettier formatting: single quotes, no semicolons, max width 100

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

src/renderer/**/*.vue

📄 CodeRabbit inference engine (AGENTS.md)

Name Vue components in PascalCase (e.g., ChatInput.vue)

Files:

src/renderer/src/components/settings/ModelCheckDialog.vue

🪛 GitHub Actions: PR Check

src/renderer/src/components/settings/ModelCheckDialog.vue

[error] 1-1: Prettier formatting check failed. Run 'prettier --write' to fix code style issues in this file.

src/renderer/src/components/settings/ModelCheckDialog.vue

zerob13 · 2025-09-30T07:59:23Z

@codex review

chatgpt-codex-connector · 2025-09-30T08:11:58Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

fix: show all models in model check dialog instead of only enabled ones

a988e0d

coderabbitai bot reviewed Sep 30, 2025

View reviewed changes

src/renderer/src/components/settings/ModelCheckDialog.vue Show resolved Hide resolved

fix: check format

f3c6223

zerob13 merged commit 835cd07 into ThinkInAIXYZ:dev Sep 30, 2025
2 checks passed

Dw9 deleted the fix/model-check-dialog-show-all-models branch October 21, 2025 03:03

coderabbitai bot mentioned this pull request Oct 25, 2025

fix: merge stored provider models when refreshing settings #1051

Merged

coderabbitai bot mentioned this pull request Nov 18, 2025

refactor: split the Setting Store into multiple single-responsibility stores. #1101

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: show all models in model check dialog instead of only enabled ones #953

fix: show all models in model check dialog instead of only enabled ones #953

Uh oh!

Dw9 commented Sep 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

zerob13 commented Sep 30, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: show all models in model check dialog instead of only enabled ones #953

fix: show all models in model check dialog instead of only enabled ones #953

Uh oh!

Conversation

Dw9 commented Sep 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root Cause

Solution

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zerob13 commented Sep 30, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dw9 commented Sep 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 30, 2025 •

edited

Loading