src/renderer/floating/env.d.ts (4)

11-20: Make API optional to match runtime checks

Renderer guards for window.floatingButtonAPI; the global type should reflect optional presence.

-    floatingButtonAPI: {
+    floatingButtonAPI?: {

---

15-17: Clarify coordinate semantics in the API

These are screen coordinates; name them accordingly for self-documenting types. No runtime change.

-      onDragStart: (x: number, y: number) => void
-      onDragMove: (x: number, y: number) => void
-      onDragEnd: (x: number, y: number) => void
+      onDragStart: (screenX: number, screenY: number) => void
+      onDragMove: (screenX: number, screenY: number) => void
+      onDragEnd: (screenX: number, screenY: number) => void

---

18-18: Remove any from callback type

Use unknown to keep strict typing without leaking any.

-      onConfigUpdate: (callback: (config: any) => void) => void
+      onConfigUpdate: (callback: (config: unknown) => void) => void

---

10-21: Deduplicate API surface typing

Define a shared FloatingButtonAPI type in src/shared/floating.ts and reuse it here and in preload to avoid drift.

src/main/events.ts (1)

179-189: Single source of truth for event names

Preload redefines these constants locally; move event names to src/shared/events.ts importable from both main and preload to prevent divergence.

src/preload/floating-preload.ts (3)

31-55: Validate coordinates before sending IPC

Guard against non-finite values; log and skip instead of sending bad payloads.

   onDragStart: (x: number, y: number) => {
     try {
+      if (!Number.isFinite(x) || !Number.isFinite(y)) {
+        console.warn('FloatingPreload: Ignoring non-finite drag start coords', { x, y })
+        return
+      }
       ipcRenderer.send(FLOATING_BUTTON_EVENTS.DRAG_START, { x, y })
     } catch (error) {
       console.error('FloatingPreload: Error sending drag start IPC message:', error)
     }
   },

   onDragMove: (x: number, y: number) => {
     try {
+      if (!Number.isFinite(x) || !Number.isFinite(y)) return
       ipcRenderer.send(FLOATING_BUTTON_EVENTS.DRAG_MOVE, { x, y })
     } catch (error) {
       console.error('FloatingPreload: Error sending drag move IPC message:', error)
     }
   },

   onDragEnd: (x: number, y: number) => {
     try {
+      if (!Number.isFinite(x) || !Number.isFinite(y)) return
       ipcRenderer.send(FLOATING_BUTTON_EVENTS.DRAG_END, { x, y })
     } catch (error) {
       console.error('FloatingPreload: Error sending drag end IPC message:', error)
     }
   },

---

4-10: Avoid duplicating event constants

Import a shared events map instead of redefining FLOATING_BUTTON_EVENTS locally to prevent drift.

---

71-83: Context isolation already enforced
The FloatingButtonWindow is instantiated with webPreferences.contextIsolation: true (src/main/presenter/floatingButtonPresenter/FloatingButtonWindow.ts:66), so process.contextIsolated will always be true and the else‐branch in src/preload/floating-preload.ts is never reached. No mandatory change required; you may optionally remove that dead fallback code.

src/renderer/floating/FloatingButton.vue (5)

12-14: Remove redundant element-level mousemove/mouseup

You already attach document listeners on mousedown; these duplicates add overhead and may double-fire.

-      @mousemove="handleMouseMove"
-      @mouseup="handleMouseUp"

---

36-46: Prefer type alias over interface (repo guideline)

Switch to type for DragState.

-interface DragState {
+type DragState = {
   isDragging: boolean
   isMouseDown: boolean
   startX: number
   startY: number
   startScreenX: number
   startScreenY: number
   dragTimer: number | null
   lastMoveTime: number
-}
+}

---

96-102: Use requestAnimationFrame for smoother throttling

Time-based 16ms check is fine; rAF is more consistent with display refresh.

-    const now = Date.now()
-    if (now - dragState.value.lastMoveTime >= 16) {
-      dragState.value.lastMoveTime = now
-      window.floatingButtonAPI?.onDragMove(event.screenX, event.screenY)
-    }
+    requestAnimationFrame(() => {
+      window.floatingButtonAPI?.onDragMove(event.screenX, event.screenY)
+    })

---

255-260: Ensure dragging style wins over :hover

Current order lets :hover override .dragging transform. Add a specific rule.

 .floating-button.dragging {
   cursor: grabbing;
   transform: scale(1.05);
   box-shadow: 0 12px 30px rgba(102, 126, 234, 0.5);
   transition: none; /* 拖拽时禁用过渡动画 */
 }
+
+.floating-button.dragging:hover {
+  transform: scale(1.05);
+  transition: none;
+}

Also applies to: 263-267

---

12-18: Renderer-to-main pathway

Repo guideline says: “From renderer to main, call presenters via the usePresenter.ts composable.” Here we call window.floatingButtonAPI directly. If floating renderer is exempt, ignore; otherwise, consider routing via the composable for consistency.

Also applies to: 164-195, 223-235

src/main/presenter/floatingButtonPresenter/index.ts (2)

163-171: Type the dragState for strict TS

Add a local type alias and annotate dragState.

// add above the declaration (outside diff range if needed)
type DragState = {
  isDragging: boolean
  startX: number
  startY: number
  windowX: number
  windowY: number
  wasFloatingChatVisible: boolean
}

-    let dragState = {
+    let dragState: DragState = {
       isDragging: false,
       startX: 0,
       startY: 0,
       windowX: 0,
       windowY: 0,
       wasFloatingChatVisible: false // 记录拖拽前浮窗是否可见
     }

---

213-215: Consider broadcasting position updates

If any renderer needs live position, emit FLOATING_BUTTON_EVENTS.POSITION_CHANGED on move.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.