src/main/utils/strings.ts (4)

7-9: Doc nit: mention tabs are collapsed too.

The implementation collapses runs of spaces and tabs, not just spaces. Align the comment to avoid confusion.

- * - Collapses multiple consecutive spaces (but preserves single line breaks)
+ * - Collapses multiple consecutive spaces and tabs (preserves line breaks)

---

26-26: Regex simplification for CR/CRLF normalization.

Slightly simpler and equivalent pattern.

-    .replace(/(\r\n|\r)/g, '\n')
+    .replace(/\r\n?/g, '\n')

---

27-27: Collapse non‑breaking spaces too (NBSP).

Restricting to [ \t]+ preserves LFs as intended, but it will leave NBSPs (0xA0) intact (common from HTML/Word copy). That can degrade tokenization and chunking. Consider including NBSP while still excluding \n.

-    .replace(/[ \t]+/g, ' ')
+    .replace(/[ \t\u00A0]+/g, ' ')

If you prefer a broader “horizontal whitespace except newline” approach, an alternative is:

.replace(/[^\S\n]+/g, ' ')

Recommend adding unit tests covering:

• CRLF/CR normalization (Windows files)
• NBSP collapsing
• Preservation of single LFs

---

23-23: Confirm intent: stripping all backslashes may mangle content.

Removing all backslashes can alter Windows paths (C:\dir\file.txt → C:dirfile.txt) and code blocks/escape sequences. If this sanitizer processes arbitrary user documents (not just plain prose), consider scoping or making this configurable.

I can draft an optioned version, e.g., sanitizeText(text, { stripBackslashes: boolean }), defaulting to current behavior, or restrict removal to known escape artifacts. Want me to open a follow-up?

src/renderer/src/i18n/ja-JP/settings.json (1)

544-547: Tweak phrasing for natural Japanese and clarity

• “ワンクリックの一時停止” is slightly awkward. “ワンクリック一時停止” is more natural in UI labels.
• “無効な分離器” is uncommon; “区切り文字” or “セパレーター” is standard.

Apply:

-    "pauseAllRunningTasks": "ワンクリックの一時停止",
+    "pauseAllRunningTasks": "ワンクリック一時停止",
-    "invalidSeparators": "無効な分離器",
+    "invalidSeparators": "無効な区切り文字",

src/renderer/src/i18n/en-US/settings.json (2)

505-505: Grammar: use “Supports …” (singular) for button/label text

Small UX polish.

-    "fileSupport": "Support {accept} and {count} other formats",
+    "fileSupport": "Supports {accept} and {count} other formats",

---

545-549: Use imperative “Load presets” for separatorsPreset

All locale files already include the separatorsPreset key—update the en-US entry and coordinate with localization to use the imperative form:

In src/renderer/src/i18n/en-US/settings.json:

-    "separatorsPreset": "Loading presets"
+    "separatorsPreset": "Load presets"

Consider propagating this change to other locales’ translations to maintain consistency.

src/renderer/src/i18n/fr-FR/settings.json (2)

545-545: Prefer “Séparateurs de blocs” (plural) for label naturalness

-    "separators": "Séparateur de blocage",
+    "separators": "Séparateurs de blocs",

---

548-548: Use imperative for action label

Keep consistent with other locales (action vs. status).

-    "separatorsPreset": "Chargement des préréglages"
+    "separatorsPreset": "Charger les préréglages"

src/renderer/src/i18n/ru-RU/settings.json (1)

543-549: Improve action label tone and preset wording

• “Пауза с одним щелчком” is awkward; prefer “Поставить на паузу одним кликом”.
• Use imperative “Загрузить пресеты” for the button label.

-    "pauseAllRunningTasks": "Пауза с одним щелчком",
+    "pauseAllRunningTasks": "Поставить на паузу одним кликом",
-    "separatorsPreset": "Загрузка пресетов"
+    "separatorsPreset": "Загрузить пресеты"

src/main/presenter/knowledgePresenter/knowledgeStorePresenter.ts (3)

63-70: Compute MIME once and persist on file record.

Getting MIME via presenter.filePresenter.getMimeType(filePath) and persisting it into fileMessage.mimeType/name improves downstream processing determinism.

You could guard against empty-string MIME results to fall back to later detection:

-const mimeType = await presenter.filePresenter.getMimeType(filePath)
+const detected = await presenter.filePresenter.getMimeType(filePath)
+const mimeType = detected && detected.trim().length > 0 ? detected : undefined

---

120-124: Respect configurable separators; add a safe fallback when empty.

Using this.config.separators enables custom chunking. If users configure an empty array, the splitter will effectively have no separators; consider falling back to defaults when the list is empty.

-const chunker = new RecursiveCharacterTextSplitter({
-  chunkSize: this.config.chunkSize,
-  chunkOverlap: this.config.chunkOverlap,
-  separators: this.config.separators
-})
+const separators =
+  Array.isArray(this.config.separators) && this.config.separators.length > 0
+    ? this.config.separators
+    : undefined
+const chunker = new RecursiveCharacterTextSplitter({
+  chunkSize: this.config.chunkSize,
+  chunkOverlap: this.config.chunkOverlap,
+  separators
+})

---

63-63: Reduce global coupling on presenter (optional).

Accessing presenter.filePresenter from inside the store presenter creates a cyclic dependency path. Consider injecting an IFilePresenter (or MIME detector) directly into KnowledgeStorePresenter to remove the global import and tighten boundaries.

src/main/presenter/filePresenter/FilePresenter.ts (2)

28-41: Temp dir init is async; simplify and make intent explicit.

Wrapping a Promise in try/catch doesn’t catch async rejections. Prefer a one-liner with explicit discard, and keep the contextual error message.

Apply:

-    try {
-      const mkdirResult = fs.mkdir(this.tempDir, { recursive: true })
-      if (mkdirResult && typeof mkdirResult.catch === 'function') {
-        mkdirResult.catch(console.error)
-      }
-    } catch (error) {
-      console.error('Failed to create temp directory:', error)
-    }
+    void fs
+      .mkdir(this.tempDir, { recursive: true })
+      .catch((err) => console.error('Failed to create temp directory:', err))

---

276-306: Supported extensions surface with sensible fallback.

Returning a sorted fallback set is good resilience. Note: the same fallback set appears in KnowledgePresenter; consider centralizing to avoid drift.

You could export a shared constant (e.g., DEFAULT_KB_EXTENSIONS) from the service module and reuse it in both places.

test/main/presenter/KnowledgePresenter.test.ts (1)

87-89: Mock vector utils on the alias used by SUT.

SUT imports getMetric from @/utils/vector. Update the mock to ensure it applies if used.

-vi.mock('../../../src/main/utils/vector', () => ({
+vi.mock('@/utils/vector', () => ({
   getMetric: vi.fn().mockReturnValue('cosine')
 }))

src/main/presenter/knowledgePresenter/index.ts (1)

422-460: Extension discovery: OK, but de-duplicate fallback lists.

You have a very similar fallback list in FilePresenter. Prefer a shared constant to avoid drift.

As a follow-up, export DEFAULT_KB_EXTENSIONS from the validation service module and use it here and in FilePresenter.

src/main/presenter/filePresenter/FileValidationService.ts (1)

50-61: Unreachable branch: AdapterConstructor is never undefined

findAdapterForMimeType always returns a constructor (falls back to UnsupportFileAdapter), so if (!AdapterConstructor) cannot be hit. Consider simplifying by checking explicitly for UnsupportFileAdapter and handling it consistently in a single path.

Example refactor (optional):

-      const AdapterConstructor = this.findAdapterForMimeType(mimeType, adapterMap)
-
-      if (!AdapterConstructor) {
-        return {
-          isSupported: false,
-          mimeType,
-          error: 'No adapter found for this file type',
-          suggestedExtensions: this.getSupportedExtensions()
-        }
-      }
+      const AdapterConstructor = this.findAdapterForMimeType(mimeType, adapterMap)

src/shared/presenter.d.ts (1)

1546-1553: Consolidate FileValidationResult into a single shared definition

The FileValidationResult interface is declared in both:

• src/shared/presenter.d.ts (lines 1546–1553)
• src/main/presenter/filePresenter/FileValidationService.ts (lines 6–13)

Maintaining two separate definitions risks them diverging over time. To avoid duplication:

• Remove the duplicate interface in FileValidationService.ts.
• Import and re-export the shared definition instead. For example, in FileValidationService.ts:

// before
export interface FileValidationResult {
  isSupported: boolean
  mimeType?: string
  adapterType?: string
  error?: string
  suggestedExtensions?: string[]
}

// after
import { FileValidationResult } from '../../../shared/presenter';
export { FileValidationResult };

This keeps a single source of truth and prevents future drift.

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (2)

347-348: ⚠️ Prefix in tooltip is user-facing; consider moving into i18n

To keep all user-visible strings behind i18n, include the warning emoji inside the translation value rather than the template literal.

---

794-806: Consider explicit clearing behavior when separators input is empty

Currently, if the input is cleared, existing separators on the config remain unchanged. If the intended UX is “clearing the input removes custom separators,” delete the field when blank.

Apply this diff:

   // 转换separators格式
   if (separators.value && separators.value.trim() !== '') {
     const separatorsArray = separatorString2Array(separators.value)
     if (separatorsArray.length === 0) {
       toast({
         title: t('settings.knowledgeBase.invalidSeparators'),
         variant: 'destructive',
         duration: 3000
       })
       submitLoading.value = false
       return
     }
     editingBuiltinConfig.value.separators = separatorsArray
   }
+  else {
+    delete editingBuiltinConfig.value.separators
+  }

src/renderer/src/components/settings/KnowledgeFile.vue (5)

73-78: Locale-aware list formatting for supported extensions; avoid hardcoded Chinese comma.

Joining with '，' hardcodes punctuation and isn’t locale-aware. Prefer a locale-aware list or at least a neutral join.

Minimal change:

-                      accept: acceptExts.slice(0, 5).join('，'),
+                      accept: acceptExts.slice(0, 5).join(', '),

Optional: Use Intl.ListFormat with the current i18n locale for better UX:

-                      accept: acceptExts.slice(0, 5).join('，'),
+                      accept: new Intl.ListFormat($i18n.locale, { style: 'short', type: 'conjunction' })
+                        .format(acceptExts.slice(0, 5)),

---

231-233: Use English for code comments per guidelines.

Comments should be in English in .vue files.

-// 允许的文件扩展名 - 动态加载
+// Allowed file extensions - dynamically loaded

---

290-307: Normalize and de-duplicate extensions; handle leading dots and casing.

Backends may return extensions with leading dots or mixed case, causing issues like “..md” in the file input accept attribute and duplicate entries in the preview. Normalize and de-duplicate before merging with defaults.

-// 加载支持的文件扩展名
+// Load supported file extensions
 const loadSupportedExtensions = async () => {
   try {
     console.log('[KnowledgeFile] Loading supported extensions from backend')
-    const extensions = await knowledgePresenter.getSupportedFileExtensions()
-    // 保证 defaultSupported 排在最前，且不重复
-    const uniqueExts = extensions.filter((ext) => !defaultSupported.includes(ext))
-    acceptExts.value = [...defaultSupported, ...uniqueExts]
-    console.log(`[KnowledgeFile] Loaded ${extensions.length} supported extensions:`, extensions)
+    const extensions = await knowledgePresenter.getSupportedFileExtensions()
+    // Normalize: trim, remove leading dot, lower-case
+    const normalize = (ext: string) => ext.trim().replace(/^\./, '').toLowerCase()
+    const normalized = Array.from(new Set(extensions.map(normalize)))
+    // Keep defaults at the front and avoid duplicates
+    const uniqueExts = normalized.filter((ext) => !defaultSupported.includes(ext))
+    acceptExts.value = [...defaultSupported, ...uniqueExts]
+    console.log(
+      `[KnowledgeFile] Loaded ${normalized.length} supported extensions:`,
+      acceptExts.value
+    )
   } catch (error) {
     console.error('[KnowledgeFile] Failed to load supported extensions:', error)
-    // 使用回退扩展名列表
+    // Fallback to default extensions
     acceptExts.value = [...defaultSupported]
   }
 }

---

309-314: Reset file input after upload to allow re-selecting the same file.

Without clearing the input, selecting the same file again won’t trigger change in many browsers.

-const handleChange = async (event: Event) => {
-  const files = (event.target as HTMLInputElement).files
+const handleChange = async (event: Event) => {
+  const input = event.target as HTMLInputElement
+  const files = input.files
   if (files && files.length > 0) {
     await handleFileUpload(Array.from(files))
   }
+  // Clear input value to enable selecting the same file again
+  input.value = ''
 }

---

424-428: Guard parallel initialization with try/catch to avoid unhandled rejections.

If loadList rejects, onMounted will throw. Wrap in try/catch to toast/log gracefully.

-onMounted(async () => {
-  // 并行加载文件列表和支持的扩展名
-  await Promise.all([loadList(), loadSupportedExtensions()])
+onMounted(async () => {
+  // Load file list and supported extensions in parallel
+  try {
+    await Promise.all([loadList(), loadSupportedExtensions()])
+  } catch (error) {
+    console.error('[KnowledgeFile] Initialization failed:', error)
+    toast({
+      title: t('common.error'),
+      description: t('settings.knowledgeBase.initFailed'),
+      variant: 'destructive',
+      duration: 3000
+    })
+  }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to test/**/*.{ts,tsx,js,jsx} : Use Vitest for unit and integration tests

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use Shadcn Vue, Radix Vue, and Tailwind for components and styling.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/**/*.ts : One presenter per functional domain

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : `src/main/presenter/llmProviderPresenter/index.ts` should manage the overall Agent loop, conversation history, tool execution via `McpPresenter`, and frontend communication via `eventBus`.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/common.json : Shared translation keys must be placed in 'src/renderer/src/i18n/common.json'

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Maintain consistent structure across all translation files

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : When adding new translations, add shared keys to 'common.json' and language-specific keys to the respective language file; keep all language files' keys consistent

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Each language must have a separate JSON file in 'src/renderer/src/i18n/'

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.{ts,tsx,vue} : Renderer to Main: Use usePresenter.ts composable for direct presenter method calls

src/renderer/src/components/settings/KnowledgeFile.vue (1)

346-350: Use i18n placeholder key for toasts (avoid mixing free text with translations)

Use a dedicated i18n key with a filename placeholder for better localization. This mirrors the prior review.

-        toast({
-          title: `"${file.name}" ${t('settings.knowledgeBase.uploadError')}`,
-          description: validationResult.error,
-          variant: 'destructive',
-          duration: 3000
-        })
+        toast({
+          title: t('settings.knowledgeBase.uploadErrorWithFilename', { filename: file.name }),
+          description: validationResult.error,
+          variant: 'destructive',
+          duration: 3000
+        })

-        toast({
-          title: `${file.name} ${t('settings.knowledgeBase.uploadError')}`,
-          description: result.error,
-          variant: 'destructive',
-          duration: 3000
-        })
+        toast({
+          title: t('settings.knowledgeBase.uploadErrorWithFilename', { filename: file.name }),
+          description: result.error,
+          variant: 'destructive',
+          duration: 3000
+        })

-      toast({
-        title: `${file.name} ${t('settings.knowledgeBase.uploadError')}`,
-        description: (error as Error).message,
-        variant: 'destructive',
-        duration: 3000
-      })
+      toast({
+        title: t('settings.knowledgeBase.uploadErrorWithFilename', { filename: file.name }),
+        description: (error as Error).message,
+        variant: 'destructive',
+        duration: 3000
+      })

Follow-up: ensure the settings.knowledgeBase.uploadErrorWithFilename key exists in every locale.

#!/bin/bash
# Verify the new i18n key exists across all locales
fd settings.json src/renderer/src/i18n -x rg -nP '"uploadErrorWithFilename"\s*:' {}

Also applies to: 361-366, 383-387

src/renderer/src/components/settings/KnowledgeFile.vue (3)

330-390: Optional: limited-concurrency uploads for large drops

Current loop is serial. For large drops this slows UX. Consider a lightweight limiter (no new deps) to process N files concurrently while relying on backend validation.

Example (outside the selected lines, for reference):

// simple limiter
const withLimit = (limit: number) => {
  let running = 0
  const queue: (() => Promise<void>)[] = []
  const runNext = () => {
    if (running >= limit || queue.length === 0) return
    running++
    const task = queue.shift()!
    task().finally(() => {
      running--
      runNext()
    })
  }
  return <T>(fn: () => Promise<T>) =>
    new Promise<T>((resolve, reject) => {
      queue.push(() => fn().then(resolve, reject) as unknown as Promise<void>)
      runNext()
    })
}

// usage
const limit = withLimit(3)
await Promise.all(files.map((f) => limit(() => processOneFile(f))))

Where processOneFile is the current per-file body inside handleFileUpload.

---

`162-162`: **Remove stray character in tooltip content**

There is an extra `<` rendered in the UI.

```diff
-                        {{ t('settings.knowledgeBase.copySuccess') }} <
+                        {{ t('settings.knowledgeBase.copySuccess') }}

---

231-231: Use English for code comments per project guidelines

Several newly added/edited comments are in Chinese. Please convert them to English to comply with repo standards.

Example changes:

-// 允许的文件扩展名 - 动态加载
+// Allowed file extensions - dynamically loaded

-// 加载支持的文件扩展名
+// Load supported file extensions

-// 处理文件上传的通用方法
+// Shared handler for file uploads (input and drag-and-drop)

-// 上传文件到内置知识库 - 拖拽处理
+// Upload files to built-in knowledge base - drag-and-drop handler

-// 初始化文件列表和支持的扩展名
+// Initialize file list and supported extensions

Also applies to: 292-293, 330-331, 392-393, 424-425

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (2)

949-955: Make logs English and add error handling and loading state for supportedLanguages (duplicate of earlier feedback)

Attach a catch to avoid unhandled rejections and log in English. Track loading state for better UX.

-const separators = ref('')
-const supportedLanguages = ref<string[]>([])
-knowledgeP.getSupportedLanguages().then((res) => {
-  supportedLanguages.value = res
-  console.log('支持的语言:', supportedLanguages.value)
-})
+const separators = ref('')
+const supportedLanguages = ref<string[]>([])
+const isLoadingLanguages = ref(false)
+isLoadingLanguages.value = true
+knowledgeP
+  .getSupportedLanguages()
+  .then((res) => {
+    supportedLanguages.value = res
+    console.log('[INFO][BuiltinKnowledgeSettings] Supported languages:', supportedLanguages.value)
+  })
+  .catch((error) => {
+    console.error('[ERROR][BuiltinKnowledgeSettings] Failed to load supported languages:', error)
+    toast({
+      title: t('common.error.operationFailed'),
+      description: String(error),
+      variant: 'destructive',
+      duration: 3000
+    })
+  })
+  .finally(() => {
+    isLoadingLanguages.value = false
+  })

---

956-961: Harden language preset loading with try/catch and always close the popover (duplicate of earlier feedback)

Avoid unhandled rejections and ensure UI closes regardless of outcome. Use English for the comment.

-// 处理语言选择
-const handleLanguageSelect = async (language: string) => {
-  separators.value = separatorsArray2String(await getSeparatorsForLanguage(language))
-  separatorsPopoverOpen.value = false
-}
+// Handle language preset selection
+const handleLanguageSelect = async (language: string) => {
+  try {
+    const arr = await getSeparatorsForLanguage(language)
+    separators.value = separatorsArray2String(arr)
+  } catch (error) {
+    console.error('[ERROR][BuiltinKnowledgeSettings] Failed to load separators for language:', language, error)
+    toast({
+      title: t('common.error.operationFailed'),
+      description: String(error),
+      variant: 'destructive',
+      duration: 3000
+    })
+  } finally {
+    separatorsPopoverOpen.value = false
+  }
+}

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (6)

395-404: Add aria-label to the “presets” icon-only button for accessibility

Icon-only controls should expose an accessible name.

-                            <Button
+                            <Button
                               size="xs"
                               variant="ghost"
                               class="whitespace-nowrap"
                               :title="t('settings.knowledgeBase.separatorsPreset')"
+                              :aria-label="t('settings.knowledgeBase.separatorsPreset')"
                             >

---

405-423: Show loading/empty state for language presets list

Provide feedback while loading and when no languages are available.

-                          <PopoverContent class="w-40 p-2">
+                          <PopoverContent class="w-40 p-2">
                             <div class="space-y-2">
                               <div class="text-sm text-secoudary">
                                 {{ t('settings.knowledgeBase.selectLanguage') }}
                               </div>
-                              <div class="max-h-48 overflow-y-auto space-y-1">
-                                <Button
-                                  v-for="language in supportedLanguages"
-                                  :key="language"
-                                  variant="ghost"
-                                  size="sm"
-                                  class="w-full justify-start text-left"
-                                  @click="handleLanguageSelect(language)"
-                                >
-                                  {{ language }}
-                                </Button>
-                              </div>
+                              <div v-if="isLoadingLanguages" class="text-xs text-muted-foreground py-1">
+                                {{ t('common.loading') }}
+                              </div>
+                              <div v-else-if="supportedLanguages.length === 0" class="text-xs text-muted-foreground py-1">
+                                {{ t('common.empty') }}
+                              </div>
+                              <div v-else class="max-h-48 overflow-y-auto space-y-1">
+                                <Button
+                                  v-for="language in supportedLanguages"
+                                  :key="language"
+                                  variant="ghost"
+                                  size="sm"
+                                  class="w-full justify-start text-left"
+                                  @click="handleLanguageSelect(language)"
+                                >
+                                  {{ language }}
+                                </Button>
+                              </div>
                             </div>
                           </PopoverContent>

---

614-615: Use English for comments

Align with repo guidelines for TS/Vue files.

-// 分隔符弹窗
+// Separators popover
 const separatorsPopoverOpen = ref(false)

---

962-965: Nit: no need for async/await in a simple forwarder

Return the promise directly; it keeps the type and avoids an extra microtask.

-const getSeparatorsForLanguage = async (language: string) => {
-  return await knowledgeP.getSeparatorsForLanguage(language)
-}
+const getSeparatorsForLanguage = (language: string) => knowledgeP.getSeparatorsForLanguage(language)

---

971-985: Use English comments and guard non-array inputs

Minor robustness: handle unexpected inputs gracefully; also translate comments.

-/**
- * separator array to string
- * @example separatorsArray2String(['\n\n', '\n', ' ', '']) // '"\n\n", "\n", " ", ""'
- * @param arr
- */
+/**
+ * Convert separator array to a quoted, escaped string list.
+ * @example separatorsArray2String(['\n\n', '\n', ' ', '']) // '"\n\n", "\n", " ", ""'
+ * @param arr string[]
+ */
 const separatorsArray2String = (arr: string[]): string => {
-  // 对特殊字符进行转义处理
-  return arr
+  // Escape special characters for safe inline display
+  if (!Array.isArray(arr)) return ''
+  return arr
     .map((s) => {
-      // 转义双引号、反斜杠、换行、回车、制表符等特殊字符
+      // Escape quotes, backslashes, newlines, carriage returns, tabs, etc.
       const escaped = s
         .replace(/\\/g, '\\\\')
         .replace(/"/g, '\\"')
         .replace(/\n/g, '\\n')
         .replace(/\r/g, '\\r')
         .replace(/\t/g, '\\t')
       return `"${escaped}"`
     })
     .join(', ')
 }

---

991-1021: Prefer English comments and minor defensive tweaks

Keep comments consistent with repo guidelines; optionally short-circuit early for empty input.

-/**
- * separator string to array, remove quotes and duplicates
- * @example separatorString2Array('"\n\n", "\n", " ", ""') // ['\n\n', '\n', ' ', '']
- * @param str
- */
+/**
+ * Parse quoted separators into an array, unescaping and de-duplicating.
+ * @example separatorString2Array('"\n\n", "\n", " ", ""') // ['\n\n', '\n', ' ', '']
+ * @param str string
+ */
 const separatorString2Array = (str: string): string[] => {
-  // 正则匹配所有被双引号包裹的内容（支持转义字符）
+  // Match all double-quoted segments (supports escapes)
   const regex = /"((?:\\.|[^"\\])*)"/g
   const matches: string[] = []
   let match
 
-  // 提取所有匹配项
+  // Extract every match
   while ((match = regex.exec(str.trim())) !== null) {
-    // 处理转义字符（将 \n、\t 等还原为实际字符）
+    // Unescape sequences (\n, \t, \r, \", \\)
     const unescaped = match[1].replace(/\\([nrt"\\])/g, (_, char) => {
       switch (char) {
         case 'n':
           return '\n'
         case 'r':
           return '\r'
         case 't':
           return '\t'
         case '"':
           return '"'
         case '\\':
           return '\\'
         default:
           return char
       }
     })
     matches.push(unescaped)
   }
 
-  // 去重并返回
+  // De-duplicate and return
   return Array.from(new Set(matches))
 }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to **/*.{ts,tsx,js,jsx,vue} : Use English for logs and comments

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : `src/main/presenter/llmProviderPresenter/index.ts` should manage the overall Agent loop, conversation history, tool execution via `McpPresenter`, and frontend communication via `eventBus`.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.{ts,tsx,vue} : Renderer to Main: Use usePresenter.ts composable for direct presenter method calls

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (4)

388-394: Localize the separators placeholder (avoid hardcoded user-visible text)

Replace the hardcoded placeholder with an i18n key.

-                        <Input
+                        <Input
                           id="edit-builtin-config-separators"
                           v-model="separators"
-                          placeholder='"\n\n", "\n", " ", ""'
+                          :placeholder="t('settings.knowledgeBase.separatorsPlaceholder')"
                           class="flex-1"
                         ></Input>

---

794-797: Translate comment to English (logic is good, comment needs localization)

You already implemented the removal logic; just convert the comment to English.

-  // 转换separators格式
+  // Convert separators string input into an array and persist/remove accordingly

---

953-959: English logs and add error handling for getSupportedLanguages()

Logs must be in English, and the IPC call should be guarded with a catch to avoid unhandled rejections and to notify users.

-const separators = ref('')
-const supportedLanguages = ref<string[]>([])
-knowledgeP.getSupportedLanguages().then((res) => {
-  supportedLanguages.value = res
-  console.log('支持的语言:', supportedLanguages.value)
-})
+const separators = ref('')
+const supportedLanguages = ref<string[]>([])
+knowledgeP
+  .getSupportedLanguages()
+  .then((res) => {
+    supportedLanguages.value = res
+    console.log('[INFO][BuiltinKnowledgeSettings] Supported languages:', supportedLanguages.value)
+  })
+  .catch((error) => {
+    console.error('[ERROR][BuiltinKnowledgeSettings] Failed to load supported languages:', error)
+    toast({
+      title: t('common.error.operationFailed'),
+      description: String(error),
+      variant: 'destructive',
+      duration: 3000
+    })
+  })

---

961-964: Harden language preset loading with try/catch and always close the popover

Prevents unhandled rejections and ensures UI closes even on errors, with user feedback.

-const handleLanguageSelect = async (language: string) => {
-  separators.value = separatorsArray2String(await getSeparatorsForLanguage(language))
-  separatorsPopoverOpen.value = false
-}
+const handleLanguageSelect = async (language: string) => {
+  try {
+    const arr = await getSeparatorsForLanguage(language)
+    separators.value = separatorsArray2String(arr)
+  } catch (error) {
+    console.error('[ERROR][BuiltinKnowledgeSettings] Failed to load separators for language:', language, error)
+    toast({
+      title: t('common.error.operationFailed'),
+      description: String(error),
+      variant: 'destructive',
+      duration: 3000
+    })
+  } finally {
+    separatorsPopoverOpen.value = false
+  }
+}

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (4)

347-347: Move the warning icon into i18n (avoid mixing literal UI text with translations)

Keep all user-visible content in translations. Put the "⚠️" inside the i18n string instead of hardcoding it in the template.

-                          <p>⚠️ {{ t('settings.knowledgeBase.normalizedHelper') }}</p>
+                          <p>{{ t('settings.knowledgeBase.normalizedHelper') }}</p>

Follow-up: update the translation value for settings.knowledgeBase.normalizedHelper to include the "⚠️" prefix. Do you want me to open a PR for the locale files?

---

614-616: Use English comments per guidelines

Convert this comment to English.

-// 分隔符弹窗
+// Separators popover

---

966-969: Nit: Remove unnecessary await and add return type

The additional await is unnecessary, and returning an explicit Promise<string[]> clarifies intent.

-const getSeparatorsForLanguage = async (language: string) => {
-  return await knowledgeP.getSeparatorsForLanguage(language)
-}
+const getSeparatorsForLanguage = (language: string): Promise<string[]> => {
+  return knowledgeP.getSeparatorsForLanguage(language)
+}

---

995-1025: Type safety and minor perf nit in separatorString2Array

Avoid implicit any for the regex exec result and avoid re-trimming on every iteration.

-const separatorString2Array = (str: string): string[] => {
-  // 正则匹配所有被双引号包裹的内容（支持转义字符）
-  const regex = /"((?:\\.|[^"\\])*)"/g
-  const matches: string[] = []
-  let match
-
-  // 提取所有匹配项
-  while ((match = regex.exec(str.trim())) !== null) {
-    // 处理转义字符（将 \n、\t 等还原为实际字符）
-    const unescaped = match[1].replace(/\\([nrt"\\])/g, (_, char) => {
+const separatorString2Array = (str: string): string[] => {
+  // Match quoted segments (supports escape sequences)
+  const regex = /"((?:\\.|[^"\\])*)"/g
+  const matches: string[] = []
+  const input = str.trim()
+  let exec: RegExpExecArray | null
+
+  // Extract all matches
+  while ((exec = regex.exec(input)) !== null) {
+    // Unescape \n, \r, \t, quotes and backslashes
+    const unescaped = exec[1].replace(/\\([nrt"\\])/g, (_, char) => {
       switch (char) {
         case 'n':
           return '\n'
         case 'r':
           return '\r'
         case 't':
           return '\t'
         case '"':
           return '"'
         case '\\':
           return '\\'
         default:
           return char
       }
     })
     matches.push(unescaped)
   }
 
   // 去重并返回
   return Array.from(new Set(matches))
 }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to **/*.{ts,tsx,js,jsx,vue} : Use English for logs and comments

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : `src/main/presenter/llmProviderPresenter/index.ts` should manage the overall Agent loop, conversation history, tool execution via `McpPresenter`, and frontend communication via `eventBus`.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.{ts,tsx,vue} : Renderer to Main: Use usePresenter.ts composable for direct presenter method calls