refactor: 将 Model Control Protocol (MCP) 重命名为 Model Context Protocol #554
Conversation
- 在多个语言的配置文件中更新了 MCP 的描述 - 修改了开发者指南中的 MCP 相关章节标题 - 更新了设置页面和 MCP 配置对话框中的描述文本
WalkthroughThis update standardizes the expansion of the MCP acronym from "Model Control Protocol" to "Model Context Protocol" across documentation and localization files in multiple languages. It also corrects related anchor links in the developer guide, ensuring consistency in terminology throughout the project. Additionally, a tooltip behavior prop was added to improve accessibility handling in the ChatConfig component. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/developer-guide.md (1)
13-13: Minor spacing in link text.
The Table of Contents entry reads[Model Context Protocol(MCP)]. For readability, consider adding a space before the parenthesis:[Model Context Protocol (MCP)].
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
docs/deeplinks.md(1 hunks)docs/developer-guide.md(1 hunks)src/renderer/src/i18n/en-US/mcp.json(1 hunks)src/renderer/src/i18n/en-US/settings.json(1 hunks)src/renderer/src/i18n/fr-FR/settings.json(1 hunks)src/renderer/src/i18n/ja-JP/mcp.json(1 hunks)src/renderer/src/i18n/ja-JP/settings.json(1 hunks)src/renderer/src/i18n/ko-KR/mcp.json(1 hunks)src/renderer/src/i18n/ko-KR/settings.json(1 hunks)src/renderer/src/i18n/ru-RU/mcp.json(1 hunks)src/renderer/src/i18n/ru-RU/settings.json(1 hunks)src/renderer/src/i18n/zh-CN/mcp.json(1 hunks)src/renderer/src/i18n/zh-HK/mcp.json(1 hunks)src/renderer/src/i18n/zh-HK/settings.json(1 hunks)src/renderer/src/i18n/zh-TW/mcp.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-check (x64)
🔇 Additional comments (13)
src/renderer/src/i18n/ru-RU/settings.json (1)
295-295: Consistent acronym update in Russian settingsThe description correctly updates the acronym expansion to "Model Context Protocol" and aligns with other localizations.
src/renderer/src/i18n/fr-FR/settings.json (1)
295-295: Consistent acronym update in French settingsThe description accurately reflects the new "Model Context Protocol" expansion and matches other language files.
src/renderer/src/i18n/ja-JP/settings.json (1)
295-295: Consistent acronym update in Japanese settingsThe description correctly replaces "Model Control Protocol" with "Model Context Protocol" while preserving Japanese grammar.
src/renderer/src/i18n/zh-TW/mcp.json (1)
3-3: Consistent acronym update in Traditional Chinese MCP settingsThe description now correctly expands MCP to "Model Context Protocol" in Traditional Chinese context.
src/renderer/src/i18n/ru-RU/mcp.json (1)
58-58: Consistent acronym update in Russian MCP settingsThe description updates the acronym expansion to "Model Context Protocol" and is aligned with the settings file.
src/renderer/src/i18n/zh-CN/mcp.json (1)
3-3: Verify localization style for parentheses
The Chinese string uses the English expansion(Model Context Protocol). Confirm whether it should instead display the Chinese term “模型上下文协议” per our i18n guidelines, or if keeping the English phrase is acceptable.src/renderer/src/i18n/zh-HK/settings.json (1)
295-295: Check Chinese expansion consistency
The settings description now uses(Model Context Protocol)in English. Please verify if the Chinese expansion “模型上下文协议” should replace “模型控制协议” here as well, or if the English parenthetical is preferred.src/renderer/src/i18n/ko-KR/mcp.json (1)
3-3: Term updated correctly in Korean
The description now accurately reflects “Model Context Protocol” in the Korean localization.src/renderer/src/i18n/en-US/mcp.json (1)
58-58: Acronym expansion corrected in English (US)
The description now uses “Model Context Protocol” for MCP, aligning with the PR’s renaming objective.src/renderer/src/i18n/zh-HK/mcp.json (1)
58-58: Uniform terminology update for MCP.
The description now correctly expands MCP to “Model Context Protocol” in Traditional Chinese, matching the PR’s objective.src/renderer/src/i18n/ja-JP/mcp.json (1)
58-58: Corrected MCP expansion in Japanese.
The description string has been updated to “Model Context Protocol,” aligning with other locales.src/renderer/src/i18n/en-US/settings.json (1)
295-295: Consistent MCP expansion in English.
The description now uses “Model Context Protocol” and matches the changes across documentation and localization.src/renderer/src/i18n/ko-KR/settings.json (1)
295-295: Updated MCP expansion in Korean.
The description now reflects “Model Context Protocol” correctly and follows Korean punctuation style.
| 通过此深度链接可以安装MCP（模型控制协议）服务配置。 | ||
|
|
||
| Use this deeplink to install Model Control Protocol (MCP) service configuration. | ||
| Use this deeplink to install Model Context Protocol (MCP) service configuration. |
There was a problem hiding this comment.
Inconsistent localization: Chinese acronym not updated
The English line now references “Model Context Protocol,” but the Chinese description above still reads “模型控制协议.” Please update it to “模型上下文协议” (or follow your Chinese localization guideline) to keep both languages in sync.
🤖 Prompt for AI Agents
In docs/deeplinks.md around lines 62 to 64, the Chinese acronym for MCP is
inconsistent with the English version. Update the Chinese phrase from “模型控制协议”
to “模型上下文协议” to match the English “Model Context Protocol” and maintain
localization consistency.
- 在 ChatConfig.vue 文件中，为 TooltipProvider 组件添加了 :ignoreNonKeyboardFocus="true" 属性 - 此修改旨在改进工具提示的显示逻辑，仅在使用键盘时触发焦点
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/renderer/src/components/ChatConfig.vue (2)
74-74: Clarify the inconsistent tooltip behavior modification.The
:ignoreNonKeyboardFocus="true"prop is only added to the system prompt's TooltipProvider, while other tooltips (lines 97, 119, 148) remain unchanged. This creates inconsistent tooltip behavior across the component.Is this intentional, or should this accessibility improvement be applied to all TooltipProvider instances for consistency?
If this should be applied consistently, consider this diff:
<TooltipProvider :ignoreNonKeyboardFocus="true"> <Tooltip> <TooltipTrigger> <Icon icon="lucide:help-circle" class="w-4 h-4 text-muted-foreground" /> </TooltipTrigger> <TooltipContent> <p>{{ t('settings.model.temperature.description') }}</p> </TooltipContent> </Tooltip> </TooltipProvider>And similar changes for the other TooltipProvider instances at lines 119 and 148.
74-74: Note: Change appears unrelated to PR objective.This tooltip behavior modification seems unrelated to the stated PR objective of renaming "Model Control Protocol" to "Model Context Protocol." Consider splitting unrelated changes into separate PRs for better change tracking and review clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/renderer/src/components/ChatConfig.vue(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-check (x64)
|
顺便加了一个交互修复。radix-ui的Popover组件下第一个tooltip组件默认行为会在Popover组件打开的时候默认展示。一定程度影响交互。 |
|
LGTM |
Pull Request Description
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
*For example: I'm always frustrated when [...] *
Describe the solution you'd like
A clear and concise description of what you want to happen.
UI/UX changes for Desktop Application
If this PR introduces UI/UX changes, please describe them in detail.
Platform Compatibility Notes
If this PR has specific platform compatibility considerations (Windows, macOS, Linux), please describe them here.
Additional context
Add any other context about the pull request here.
Pull Request Description (中文)
你的功能请求是否与某个问题有关？请描述一下。
请对问题进行清晰扼要的描述。
*例如：我增加了 [...] 的功能 *
请描述你希望的解决方案
请对你希望实现的效果进行清晰扼要的描述。
桌面应用程序的 UI/UX 更改
如果此 PR 引入了 UI/UX 更改，请详细描述它们。
平台兼容性注意事项
如果此 PR 具有特定的平台兼容性考虑因素（Windows、macOS、Linux），请在此处描述。
附加背景
在此处添加关于此 Pull Request 的任何其他背景信息。
Summary by CodeRabbit
Documentation
Style
Bug Fixes