Feature/enhance provider api | openrouter和ppio支持动态获取模型参数 #527

zerob13 · 2025-06-17T14:54:13Z

Pull Request Description (中文)

你的功能请求是否与某个问题有关？请描述一下。
解析了ppio和openrouter的models 接口中的额外参数，从而能准确的自动化设置模型的token和各类参数

Summary by CodeRabbit

New Features
- Improved support for dynamically fetching and updating model configurations from OpenRouter and PPIO providers, enabling automatic recognition of model capabilities such as reasoning, function calling, and vision.
Bug Fixes
- Updated the reasoning capability for the 'minimax-m1-80k' model, ensuring it is now correctly recognized as supporting reasoning.

coderabbitai · 2025-06-17T14:54:19Z

Walkthrough

This update introduces dynamic fetching and configuration of model metadata for both OpenRouter and PPIO providers, including new TypeScript interfaces and enhanced capability detection. It also updates the reasoning capability flag for the 'minimax-m1-80k' model in both default and provider-specific settings, reflecting improved reasoning support.

Changes

File(s)	Change Summary
src/main/presenter/configPresenter/modelDefaultSettings.ts	Changed `reasoning` property from false to true for the 'minimax-m1-80k' model.
src/main/presenter/configPresenter/providerModelSettings.ts	Updated `reasoning` property to true for 'minimaxai/minimax-m1-80k' in PPIO provider settings.
src/main/presenter/llmProviderPresenter/providers/openRouterProvider.ts	Added `OpenRouterModelResponse` interface and overridden `fetchOpenAIModels` method; updates model config on fetch.
src/main/presenter/llmProviderPresenter/providers/ppioProvider.ts	Added `PPIOModelResponse` interface and overridden `fetchOpenAIModels` method; updates model config on fetch.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Provider (OpenRouter/PPIO)
    participant API
    participant ConfigPresenter

    User->>Provider: fetchOpenAIModels()
    Provider->>API: Fetch models list
    API-->>Provider: Return model metadata
    Provider->>ConfigPresenter: Update model configuration if changed
    Provider-->>User: Return processed MODEL_META array

Poem

In the warren of code, new models appear,
With reasoning bright, their purpose is clear.
Providers now fetch, update, and know,
Capabilities grow as the data flows.
A hop and a skip, the configs align—
This rabbit is pleased, the future looks fine! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3472359 and 55f4de6.

📒 Files selected for processing (1)

src/main/presenter/llmProviderPresenter/providers/openRouterProvider.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/main/presenter/llmProviderPresenter/providers/openRouterProvider.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build-check (x64)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 4

♻️ Duplicate comments (1)

src/main/presenter/llmProviderPresenter/providers/ppioProvider.ts (1)

10-23: Same optional-field issue as OpenRouter interface

features, context_size, etc. can be missing; mark them optional to match runtime data.

🧹 Nitpick comments (5)

src/main/presenter/llmProviderPresenter/providers/openRouterProvider.ts (3)
234-256: configChanged comparison risks NPE & misses deep equality

Besides the undefined issue above, comparing primitives on possibly-undefined values is fine, but once guarded, you can collapse the check:
const configChanged = JSON.stringify(existingConfig) !== JSON.stringify(newConfig)
Not performance-critical here (< 200 models).

259-276: MODEL_META misses type – information lost

You build modelMeta without carrying over type (embedding/chat).
If existingConfig.type === ModelType.Embedding, this metadata will silently drop it, leading to a chat-only assumption elsewhere.
   reasoning: hasReasoning || existingConfig.reasoning || false,
+  type: existingConfig.type
276-283: Remove noisy console log before shipping

console.log of every fetch floods production logs and leaks model counts.
Use a debug logger or feature flag instead.
src/main/presenter/llmProviderPresenter/providers/ppioProvider.ts (2)
204-218: Persist type and reasoning into MODEL_META

As with OpenRouter, type and the newly detected reasoning capability are dropped:
-  reasoning: existingConfig.reasoning || false
+  reasoning: existingConfig.reasoning || false,
+  type: existingConfig.type
222-227: Debug log – strip in production

Remove or guard the console.log to keep server logs clean.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa8a91a and 3472359.

📒 Files selected for processing (4)

src/main/presenter/configPresenter/modelDefaultSettings.ts (1 hunks)
src/main/presenter/configPresenter/providerModelSettings.ts (1 hunks)
src/main/presenter/llmProviderPresenter/providers/openRouterProvider.ts (3 hunks)
src/main/presenter/llmProviderPresenter/providers/ppioProvider.ts (3 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/main/presenter/llmProviderPresenter/providers/ppioProvider.ts (1)

src/shared/presenter.d.ts (1)

MODEL_META (439-452)

src/main/presenter/llmProviderPresenter/providers/openRouterProvider.ts (1)

src/shared/presenter.d.ts (1)

MODEL_META (439-452)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build-check (x64)

🔇 Additional comments (2)

src/main/presenter/configPresenter/modelDefaultSettings.ts (1)

1351-1362: Reasoning flag looks good – check for downstream assumptions

Changing reasoning to true is consistent with the provider-side update.
Just make sure any feature-gating elsewhere (UI badges, prompts, pricing, etc.) now treats this model as “reasoning-capable”; otherwise the flag will have no visible effect.

src/main/presenter/configPresenter/providerModelSettings.ts (1)

468-481: Keep the flag in sync with dynamic fetch

Setting reasoning: true here aligns the static config with the new dynamic fetch logic – ✅.
Double-check that PPIOProvider.fetchOpenAIModels does not overwrite this back to false (it currently takes existingConfig.reasoning, see comment in that file).

src/main/presenter/llmProviderPresenter/providers/openRouterProvider.ts

src/main/presenter/llmProviderPresenter/providers/ppioProvider.ts

zerob13 added 3 commits June 17, 2025 22:32

feat: support ppio model config api

ba91e0a

feat: openrouter model config api

007746c

chore: format code

3472359

coderabbitai bot reviewed Jun 17, 2025

View reviewed changes

fix: code rabbit fix

55f4de6

zerob13 merged commit 58da015 into dev Jun 18, 2025
2 checks passed

coderabbitai bot mentioned this pull request Jul 7, 2025

Feature/302 provider model api #582

Merged

This was referenced Aug 14, 2025

fix: resolve OpenRouter model sync timeout and welcome view UI issues #738

Merged

feat: add comprehensive OpenAI reasoning models support for OpenRouter #751

Merged

zerob13 deleted the feature/enhance-provider-api branch September 21, 2025 14:48

This was referenced Oct 14, 2025

feat: add cherryin provider #993

Merged

fix: add fallback model lookup when provider missing #1001

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/enhance provider api | openrouter和ppio支持动态获取模型参数 #527

Feature/enhance provider api | openrouter和ppio支持动态获取模型参数 #527

Uh oh!

zerob13 commented Jun 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 17, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Feature/enhance provider api | openrouter和ppio支持动态获取模型参数 #527

Feature/enhance provider api | openrouter和ppio支持动态获取模型参数 #527

Uh oh!

Conversation

zerob13 commented Jun 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description (中文)

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zerob13 commented Jun 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)