fix: fix tooltip content not hiding #1146

zhangmo8 · 2025-12-01T08:04:32Z

Summary by CodeRabbit

Bug Fixes
- Enhanced tooltip focus behavior in the message interface to improve keyboard navigation support, ensuring tooltips display appropriately based on keyboard focus states rather than other input methods.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-01T08:04:53Z

Walkthrough

The pull request adds a new ignore-non-keyboard-focus prop to the TooltipProvider component in MessageToolbar.vue, set to true. This configuration change addresses a tooltip focus behavior issue without introducing new logic or control-flow modifications.

Changes

Cohort / File(s)	Summary
Tooltip Focus Configuration `src/renderer/src/components/message/MessageToolbar.vue`	Added `ignore-non-keyboard-focus="true"` prop to `TooltipProvider` to control focus behavior and prevent tooltip residue

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Verify the prop name and syntax are correct for the TooltipProvider component
Confirm that setting ignore-non-keyboard-focus="true" resolves the tooltip residue issue described in the linked issue

Poem

🐰 A tooltip that clung like morning dew,
Now vanishes with a prop that's true—
ignore-non-keyboard-focus shines so bright,
No more "copy" ghosts in the night! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing the tooltip content not hiding issue, which directly addresses the bug in issue #1141.
Linked Issues check	✅ Passed	The PR adds the ignore-non-keyboard-focus prop to TooltipProvider, which is a focused fix for preventing tooltip persistence when focus is lost, directly addressing issue #1141's requirement.
Out of Scope Changes check	✅ Passed	All changes are confined to MessageToolbar.vue and directly target the tooltip focus behavior issue reported in #1141 with no unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8831be1 and b72445f.

📒 Files selected for processing (1)

src/renderer/src/components/message/MessageToolbar.vue (1 hunks)

🧰 Additional context used

📓 Path-based instructions (14)

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use English for logs and comments (Chinese text exists in legacy code, but new code should use English)

Files:

src/renderer/src/components/message/MessageToolbar.vue

**/*.vue

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.vue: Use Vue 3 Composition API for all components instead of Options API
Use Tailwind CSS with scoped styles for component styling

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/**/*.vue

📄 CodeRabbit inference engine (CLAUDE.md)

src/renderer/**/*.vue: All user-facing strings must use i18n keys via vue-i18n for internationalization
Ensure proper error handling and loading states in all UI components
Implement responsive design using Tailwind CSS utilities for all UI components

src/renderer/**/*.vue: Use composition API and declarative programming patterns; avoid options API
Structure files: exported component, composables, helpers, static content, types
Use PascalCase for component names (e.g., AuthWizard.vue)
Use Vue 3 with TypeScript, leveraging defineComponent and PropType
Use template syntax for declarative rendering
Use Shadcn Vue, Radix Vue, and Tailwind for components and styling
Implement responsive design with Tailwind CSS; use a mobile-first approach
Use Suspense for asynchronous components
Use <script setup> syntax for concise component definitions
Prefer 'lucide:' icon family as the primary choice for Iconify icons
Import Icon component from '@iconify/vue' and use with lucide icons following pattern '{collection}:{icon-name}'

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*.{vue,ts,tsx}: All user-facing strings must use i18n keys with vue-i18n framework in the renderer
Import and use useI18n() composable with the t() function to access translations in Vue components and TypeScript files
Use the dynamic locale.value property to switch languages at runtime
Avoid hardcoding user-facing text and ensure all user-visible text uses the i18n translation system

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/**/*

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

New features should be developed in the src directory

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/**/*.{vue,js,ts}

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Renderer process code should be placed in src/renderer (Vue 3 application)

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability in Vue.js applications
Implement proper state management with Pinia in Vue.js applications
Utilize Vue Router for navigation and route management in Vue.js applications
Leverage Vue's built-in reactivity system for efficient data handling

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/src/**/*.vue

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

Use scoped styles to prevent CSS conflicts between Vue components

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Write concise, technical TypeScript code with accurate examples
Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError)
Avoid enums; use const objects instead
Use arrow functions for methods and computed properties
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements

Vue 3 app code in src/renderer/src should be organized into components/, stores/, views/, i18n/, lib/ directories with shell UI in src/renderer/shell/

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/**

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

Use lowercase with dashes for directories (e.g., components/auth-wizard)

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/**/*.{ts,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching
Leverage ref, reactive, and computed for reactive state management
Use provide/inject for dependency injection when appropriate
Use Iconify/Vue for icon implementation

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/renderer/src/**/*.{ts,tsx,vue}: Use TypeScript with Vue 3 Composition API for the renderer application
All user-facing strings must use vue-i18n keys in src/renderer/src/i18n

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/renderer/src/components/**/*.vue

📄 CodeRabbit inference engine (AGENTS.md)

src/renderer/src/components/**/*.vue: Use Tailwind for styles in Vue components
Vue component files must use PascalCase naming (e.g., ChatInput.vue)

Files:

src/renderer/src/components/message/MessageToolbar.vue

src/**/*.{ts,tsx,vue,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier with single quotes, no semicolons, and 100 character width

Files:

src/renderer/src/components/message/MessageToolbar.vue

🧠 Learnings (1)

📚 Learning: 2025-11-25T05:26:43.510Z

Learnt from: CR
Repo: ThinkInAIXYZ/deepchat PR: 0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-11-25T05:26:43.510Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx} : Avoid hardcoding user-facing text and ensure all user-visible text uses the i18n translation system

Applied to files:

src/renderer/src/components/message/MessageToolbar.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build-check (x64)

🔇 Additional comments (1)

src/renderer/src/components/message/MessageToolbar.vue (1)

3-3: TooltipProvider ignore-non-keyboard-focus usage is correct and i18n compliant

The :ignore-non-keyboard-focus="true" binding correctly implements the Radix Vue TooltipProvider API (kebab-case template syntax maps to the ignoreNonKeyboardFocus prop). All user-facing strings in the component properly use i18n keys via the useI18n() composable, so localization requirements are satisfied. The component correctly uses t('buttons.copy'), t('buttons.edit'), t('buttons.regenerate'), and t('buttons.delete') for all button labels.

To complete this fix, verify that tooltips no longer persist after quick sequential toolbar interactions (copy → regenerate, etc.) and that keyboard focus still opens tooltips as expected.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

zhangmo8 added 2 commits December 1, 2025 16:01

fix: fix tooltip content not hiding

b451754

fix: format

b72445f

zerob13 merged commit 3e1e926 into ThinkInAIXYZ:dev Dec 1, 2025
2 checks passed

zhangmo8 deleted the fix-tooltip branch December 1, 2025 10:11

coderabbitai bot mentioned this pull request Dec 29, 2025

fix(config): refine model type inference and tooltip focus behavior #1233

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: fix tooltip content not hiding #1146

fix: fix tooltip content not hiding #1146

Uh oh!

zhangmo8 commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: fix tooltip content not hiding #1146

fix: fix tooltip content not hiding #1146

Uh oh!

Conversation

zhangmo8 commented Dec 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zhangmo8 commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 1, 2025 •

edited

Loading