fix: code review

zerob13 · zerob13 · commit e1fafd6522f5 · 2025-12-11T16:42:08.000+08:00
diff --git a/src/main/presenter/llmProviderPresenter/agent/acpProcessManager.ts b/src/main/presenter/llmProviderPresenter/agent/acpProcessManager.ts
@@ -1037,12 +1037,6 @@ export class AcpProcessManager implements AgentProcessManager<AcpProcessHandle,
     this.agentLocks.set(agentId, currentLock)
     await previousLock
 
-    // Debug: show queued locks count for the agent
-    const queued = this.agentLocks.has(agentId) ? 1 : 0
-    if (queued > 1) {
-      console.info(`[ACP] Agent ${agentId} lock queue depth: ${queued}`)
-    }
-
     return () => {
       releaseResolver?.()
       if (this.agentLocks.get(agentId) === currentLock) {
diff --git a/src/main/presenter/llmProviderPresenter/providers/acpProvider.ts b/src/main/presenter/llmProviderPresenter/providers/acpProvider.ts
@@ -493,6 +493,15 @@ export class AcpProvider extends BaseAgentProvider<
     let disposePermission: (() => void) | undefined
 
     const attachSession = (sessionId: string) => {
+      if (disposeNotification) {
+        disposeNotification()
+        disposeNotification = undefined
+      }
+      if (disposePermission) {
+        disposePermission()
+        disposePermission = undefined
+      }
+
       disposeNotification = this.processManager.registerSessionListener(
         agent.id,
         sessionId,
diff --git a/src/renderer/src/i18n/da-DK/settings.json b/src/renderer/src/i18n/da-DK/settings.json
@@ -946,23 +946,23 @@
       "copyFailed": "Kunne ikke kopiere"
     },
     "debug": {
-      "clearHistory": "klar rekord",
-      "close": "lukning",
+      "clearHistory": "Ryd historik",
+      "close": "Luk",
       "customMethod": "Navn på tilpasset metode",
       "customMethodPlaceholder": "For eksempel session/ping",
       "customMethodRequired": "Udfyld venligst udvidelsesmetodens navn",
       "description": "Send en ACP-anmodning til \"{name}\", og se svaret i realtid.",
       "empty": "Der er ingen fejlretningsbegivenheder endnu.",
-      "entry": "debug",
-      "eventCount": "{count} varer",
+      "entry": "Fejlsøg",
+      "eventCount": "{count} hændelser",
       "eventKinds": {
         "error": "fejl",
-        "notification": "underrette",
-        "permission": "Tilladelser",
-        "request": "spørge",
-        "response": "svar"
+        "notification": "Meddelelse",
+        "permission": "Tilladelse",
+        "request": "Anmodning",
+        "response": "Svar"
       },
-      "events": "tilfælde",
+      "events": "Hændelser",
       "format": "Formater JSON",
       "methods": {
         "cancel": "session/aflys",
@@ -984,7 +984,7 @@
       "resetTemplate": "Gendannelsesskabelon",
       "send": "Send anmodning",
       "sending": "Sender...",
-      "title": "ACP debugging",
+      "title": "ACP-fejlsøgning",
       "workdirPlaceholder": "Lad tom for at bruge standard arbejdsmappe"
     }
   },
diff --git a/src/renderer/src/i18n/fa-IR/settings.json b/src/renderer/src/i18n/fa-IR/settings.json
@@ -972,20 +972,20 @@
       "title": "عدم وابستگی خارجی"
     },
     "debug": {
-      "clearHistory": "رکورد پاک",
-      "close": "بسته شدن",
+      "clearHistory": "پاک کردن تاریخچه",
+      "close": "بستن",
       "customMethod": "نام روش سفارشی",
       "customMethodPlaceholder": "به عنوان مثال جلسه / پینگ",
       "customMethodRequired": "لطفاً نام روش پسوند را وارد کنید",
       "description": "یک درخواست ACP به \"{name}\" ارسال کنید و پاسخ را در زمان واقعی مشاهده کنید.",
-      "empty": "هنوز هیچ رویداد اشکال زدایی وجود ندارد.",
+      "empty": "هنوز هیچ رویداد اشکال‌زدایی وجود ندارد.",
       "entry": "اشکال زدایی",
       "eventCount": "{count} مورد",
       "eventKinds": {
         "error": "اشتباه",
-        "notification": "اطلاع دهد",
+        "notification": "اعلان",
         "permission": "مجوزها",
-        "request": "بپرسید",
+        "request": "درخواست",
         "response": "پاسخ"
       },
       "events": "رویداد",
diff --git a/src/renderer/src/i18n/ko-KR/settings.json b/src/renderer/src/i18n/ko-KR/settings.json
@@ -973,7 +973,7 @@
     },
     "debug": {
       "clearHistory": "기록 지우기",
-      "close": "폐쇄",
+      "close": "닫기",
       "customMethod": "커스텀 메소드 이름",
       "customMethodPlaceholder": "예를 들어 세션/핑",
       "customMethodRequired": "확장 메서드 이름을 입력하세요.",
@@ -982,24 +982,24 @@
       "entry": "디버그",
       "eventCount": "{count}개 항목",
       "eventKinds": {
-        "error": "실수",
-        "notification": "통지하다",
+        "error": "오류",
+        "notification": "알림",
         "permission": "권한",
-        "request": "묻다",
+        "request": "요청",
         "response": "응답"
       },
       "events": "이벤트",
       "format": "JSON 형식",
       "methods": {
-        "cancel": "세션/취소",
-        "extMethod": "확장/방법",
-        "extNotification": "내선/알림",
-        "initialize": "초기화",
-        "loadSession": "세션/로드",
-        "newSession": "세션/새",
-        "prompt": "세션/프롬프트",
-        "setSessionMode": "세션/설정 모드",
-        "setSessionModel": "세션/세트모델"
+        "cancel": "session/cancel",
+        "extMethod": "ext/method",
+        "extNotification": "ext/notification",
+        "initialize": "initialize",
+        "loadSession": "session/load",
+        "newSession": "session/new",
+        "prompt": "session/prompt",
+        "setSessionMode": "session/setMode",
+        "setSessionModel": "session/setModel"
       },
       "needInitialize": "먼저 초기화를 실행해 주세요",
       "parseError": "JSON 구문 분석에 실패했습니다.",
@@ -1009,7 +1009,7 @@
       "requestFailed": "요청 실패",
       "resetTemplate": "복구 템플릿",
       "send": "요청 보내기",
-      "sending": "배상...",
+      "sending": "전송 중...",
       "title": "ACP 디버깅",
       "workdirPlaceholder": "기본 작업 디렉터리를 사용하려면 비워 두세요."
     }
diff --git a/src/renderer/src/i18n/pt-BR/settings.json b/src/renderer/src/i18n/pt-BR/settings.json
@@ -980,7 +980,7 @@
       "description": "Envie uma solicitação ACP para \"{name}\" e veja a resposta em tempo real.",
       "empty": "Ainda não há eventos de depuração.",
       "entry": "depurar",
-      "eventCount": "{contar} itens",
+      "eventCount": "{count} itens",
       "eventKinds": {
         "error": "erro",
         "notification": "notificar",
diff --git a/src/renderer/src/i18n/ru-RU/settings.json b/src/renderer/src/i18n/ru-RU/settings.json
@@ -972,23 +972,23 @@
       "title": "Отсутствуют внешние зависимости"
     },
     "debug": {
-      "clearHistory": "очистить запись",
-      "close": "закрытие",
+      "clearHistory": "Очистить историю",
+      "close": "Закрыть",
       "customMethod": "Имя пользовательского метода",
       "customMethodPlaceholder": "Например сеанс/пинг",
       "customMethodRequired": "Пожалуйста, введите имя метода расширения",
       "description": "Отправьте запрос ACP на «{name}» и просмотрите ответ в режиме реального времени.",
       "empty": "Отладочных событий пока нет.",
-      "entry": "отлаживать",
-      "eventCount": "{count} предметов",
+      "entry": "Отладка",
+      "eventCount": "{count} событий",
       "eventKinds": {
         "error": "ошибка",
-        "notification": "уведомить",
-        "permission": "Разрешения",
-        "request": "просить",
-        "response": "ответ"
+        "notification": "Уведомление",
+        "permission": "Разрешение",
+        "request": "Запрос",
+        "response": "Ответ"
       },
-      "events": "событие",
+      "events": "События",
       "format": "Формат JSON",
       "methods": {
         "cancel": "сеанс/отмена",
@@ -1009,7 +1009,7 @@
       "requestFailed": "Запрос не выполнен",
       "resetTemplate": "Шаблон восстановления",
       "send": "Отправить запрос",
-      "sending": "Отправка...",
+      "sending": "Отправка…",
       "title": "Отладка ACP",
       "workdirPlaceholder": "Оставьте пустым, чтобы использовать рабочий каталог по умолчанию."
     }
