Update androidx by vokhuyetOz · Pull Request #1626 · TheWidlarzGroup/react-native-video

vokhuyetOz · 2019-06-19T07:46:47Z

Just migrating to AndroidX

vokhuyetOz · 2019-06-19T15:25:19Z

Oh, it is my mistake, I used react-native link twice

vokhuyetOz · 2019-06-19T15:25:46Z

I will make a commit tomorrow

jensellfors · 2019-06-19T15:25:51Z

Thanks for this @vokhuyetOz. Looks like this forces people to use AndroidX? Or is this backwards compatible? (I'm not too familiar with Android :p )

vokhuyetOz · 2019-06-19T15:35:30Z

Now, people have to use AndroidX whenever upgrade to new build tool version. As I know, google moves android support responsibilities to new location

vokhuyetOz · 2019-06-19T15:38:57Z

From yesterday, I couldn’t build android app, the error is can’t import v4 AppCompat

jensellfors · 2019-06-19T16:04:31Z

Have you upgraded to RN 0.60RC? From my understanding this will only be required after upgrading to RN 0.60 react-native-community/discussions-and-proposals#129

jensellfors · 2019-06-19T16:05:16Z

And btw, I installed from your branch and then the android build fails. So it's not backwards compatible.

vokhuyetOz · 2019-06-19T16:05:46Z

No, i still use 0.59

vokhuyetOz · 2019-06-19T16:07:45Z

I just run it in example, i will check it again tomorrow, thank you for your report :)

vokhuyetOz · 2019-06-20T02:27:50Z

@jenshandersson which error did you have?
i try and it works.

vokhuyetOz · 2019-06-20T02:29:39Z

make sure that you have updated your gradle.properties and app/build.gradle.
i just have updated read.me file for this change :)

kuraydev · 2019-06-20T10:11:49Z

Waiting for this PR :) Thank you @vokhuyetOz

jensellfors · 2019-06-20T10:32:46Z

@vokhuyetOz after doing your changes I get compile errors in other 3rd party libs... I assume those haven't been upgraded to use AndroidX then? One of them is react-native-gesture-handler (that is the error I'm getting as well).

> Task :react-native-gesture-handler:compileDebugJavaWithJavac FAILED
/Users/jensa/Developer/jensun/wingsy/RNWingsy/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerEvent.java:3: error: package android.support.v4.util does not exist
import android.support.v4.util.Pools;

> Task :react-native-purchases:compileDebugJavaWithJavac FAILED
/Users/jensa/Developer/jensun/wingsy/RNWingsy/node_modules/react-native-purchases/android/src/main/java/com/reactlibrary/RNPurchasesModule.java:4: error: package android.support.annotation does not exist
import android.support.annotation.Nullable;

How do you propose I/we move forward with this? If we would merge this PR then a lot of people would have the same issues, right? (Sorry again for being a bit slow on the Android side)

vokhuyetOz · 2019-06-20T10:46:05Z

a lot of libraries must migrate to AndroidX to fix it

vokhuyetOz · 2019-06-20T10:46:57Z

i am also making a pull request for another library

vokhuyetOz · 2019-06-20T10:53:03Z

i think i should make a PR for react-native-gesture-handler to fix it

vokhuyetOz · 2019-06-20T10:53:50Z

@WrathChaos could you test this project?

kuraydev · 2019-06-20T11:07:16Z

@vokhuyetOz I already tried it, other libraries also crushes :( We need to update all of them... AndroidX ruined my day..

vokhuyetOz · 2019-06-20T12:36:22Z

you should create a new project and check only this library :)

kuraydev · 2019-06-20T12:49:29Z

@vokhuyetOz I will try it when I have time :) Thank you for this contribution anyway.

jensellfors · 2019-06-20T13:46:26Z

@vokhuyetOz after speaking to @kelset I now understand that AndroidX upgrade is not required. Since rn-video has a + as fallback in the build.gradle it will automatically pull in the latest version, and that is AndroidX. Instead of + we need to specify a version. (Anyone with Android knowledge please jump in here if I'm wrong)

Can you please create a new PR with setting explicit versions instead. Upgrading to 28 is fine. But we can't force a AndroidX upgrade of all users right now. See this PR: react-native-device-info/react-native-device-info@9588763

We will keep this PR as it will be required to move to AndroidX for RN 0.60, but let's wait with that.

vokhuyetOz · 2019-06-20T14:48:49Z

Thank you, at the moment, it is not required, but from 11/2019 developers must update their apps whenever create or update new version. I will take a look at react native device info and make a change

vokhuyetOz · 2019-06-21T03:01:34Z

@jenshandersson please check out #1629 . thank you !

n1ru4l · 2019-07-04T08:04:23Z

react-native 0.60 has now its first stable release. Should merge this asap and publish a new major release.

CHaNGeTe · 2019-07-05T15:42:07Z

This PR will make also possible to update exoplayer to 2.10.x? or totally unrelated?

CHaNGeTe · 2019-07-09T09:04:37Z

Can we align with this PR also?
#1660

vokhuyetOz · 2019-07-10T13:59:42Z

Yes, of course

CHaNGeTe · 2019-07-12T08:32:06Z

@vokhuyetOz does this change the min version of React required?

vokhuyetOz · 2019-07-13T01:48:43Z

@CHaNGeTe no, it doesn't relate to min version of react required, sorry for my late.

CHaNGeTe · 2019-07-18T08:42:30Z

hey @ashnfb @cobarx @n1ru4l @jenshandersson I need another approval for this one

n1ru4l

Legit for breaking change release (major version number bump)

CHaNGeTe · 2019-07-20T09:37:40Z

What makes it breaking change? (if RN version required does not change)

n1ru4l · 2019-07-20T13:46:26Z

Doesn’t this force the user into changing their grade setup/ using jetifier?

CHaNGeTe · 2019-07-20T14:01:03Z

ok! clear now!

Make installation parts easier to link

fix typo

Make more obvious the changes needed via using diff

fix indent

CHaNGeTe · 2019-07-23T10:04:28Z

@vokhuyetOz I am preparing the merge. Do you know the minimum required gradle version for this to work?

agungkes · 2019-07-23T10:42:13Z

Aha it's good to know this PR will merge
Thanks you @CHaNGeTe

karltaylor · 2019-07-23T11:26:43Z

Woohoo! 🎉

benoitdion · 2019-07-23T13:39:08Z

-    implementation "com.android.support:support-annotations:${safeExtGet('supportLibVersion', '+')}"
-    implementation "com.android.support:support-compat:${safeExtGet('supportLibVersion', '+')}"
-    implementation "com.android.support:support-media-compat:${safeExtGet('supportLibVersion', '+')}"
+    // implementation "com.android.support:support-annotations:${safeExtGet('supportLibVersion', '+')}"


can this be removed instead of commented out?

benoitdion · 2019-07-23T13:39:47Z

        release {
            signingConfig signingConfigs.debug
            minifyEnabled enableProguardInReleaseBuilds
+            matchingFallbacks = ['release', 'debug']


why is this needed?

i don't remember exactly why i add it. i will remove it in the next commit :D

vokhuyetOz · 2019-07-24T02:09:33Z

@vokhuyetOz I am preparing the merge. Do you know the minimum required gradle version for this to work?

sorry, i don't find any information about the minimum required gradle version. But i find

Hope it helps you!

jensellfors reviewed Jun 19, 2019

View reviewed changes

Comment thread examples/basic/android/app/src/main/java/com/videoplayer/MainApplication.java Outdated

n1ru4l requested review from CHaNGeTe, cobarx and n1ru4l July 4, 2019 08:03

benoitdion reviewed Jul 5, 2019

View reviewed changes

Comment thread examples/basic/android/build.gradle Outdated

Comment thread examples/basic/android/settings.gradle Outdated

CHaNGeTe mentioned this pull request Jul 9, 2019

rm rnpm & use androidX #1660

Closed

remove rnpm

47e1630

CHaNGeTe added candidate for next release labels Jul 10, 2019

tslater mentioned this pull request Jul 11, 2019

rnpm & AndroidX for next release #1656

Closed

CHaNGeTe approved these changes Jul 15, 2019

View reviewed changes

CHaNGeTe requested review from ashnfb and jensellfors July 15, 2019 07:22

jensellfors approved these changes Jul 19, 2019

View reviewed changes

n1ru4l approved these changes Jul 19, 2019

View reviewed changes

CHaNGeTe added 4 commits July 23, 2019 11:29

Update README.md

95060d7

Make installation parts easier to link

Update README.md

66a85ae

fix typo

Update README.md

62ff44a

Make more obvious the changes needed via using diff

Update MainApplication.java

d748d17

fix indent

benoitdion reviewed Jul 23, 2019

View reviewed changes

remove matchingfallbacks in example

222adf5

Merge branch 'release/5.0.0' into update-androidx

a45e857

CHaNGeTe merged commit 1fb07b5 into TheWidlarzGroup:release/5.0.0 Jul 25, 2019

Conversation

vokhuyetOz commented Jun 19, 2019

Uh oh!

Uh oh!

vokhuyetOz commented Jun 19, 2019

Uh oh!

vokhuyetOz commented Jun 19, 2019

Uh oh!

jensellfors commented Jun 19, 2019

Uh oh!

vokhuyetOz commented Jun 19, 2019

Uh oh!

vokhuyetOz commented Jun 19, 2019

Uh oh!

jensellfors commented Jun 19, 2019

Uh oh!

jensellfors commented Jun 19, 2019

Uh oh!

vokhuyetOz commented Jun 19, 2019

Uh oh!

vokhuyetOz commented Jun 19, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kuraydev commented Jun 20, 2019

Uh oh!

jensellfors commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019

Uh oh!

kuraydev commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019

Uh oh!

kuraydev commented Jun 20, 2019

Uh oh!

jensellfors commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 20, 2019

Uh oh!

vokhuyetOz commented Jun 21, 2019

Uh oh!

n1ru4l commented Jul 4, 2019

Uh oh!

CHaNGeTe commented Jul 5, 2019

Uh oh!

Uh oh!

Uh oh!

CHaNGeTe commented Jul 9, 2019

Uh oh!

vokhuyetOz commented Jul 10, 2019

Uh oh!

CHaNGeTe commented Jul 12, 2019

Uh oh!

vokhuyetOz commented Jul 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CHaNGeTe commented Jul 18, 2019

Uh oh!

n1ru4l left a comment

Choose a reason for hiding this comment

Uh oh!

CHaNGeTe commented Jul 20, 2019

Uh oh!

n1ru4l commented Jul 20, 2019

Uh oh!

CHaNGeTe commented Jul 20, 2019

Uh oh!

CHaNGeTe commented Jul 23, 2019

Uh oh!

agungkes commented Jul 23, 2019

vokhuyetOz commented Jun 20, 2019 •

edited

Loading

vokhuyetOz commented Jul 13, 2019 •

edited

Loading

vokhuyetOz commented Jul 24, 2019 •

edited

Loading