Fixed blue LED bug with cayenne LPP device#17
Merged
johanstokking merged 2 commits intoTheThingsNetwork:masterfrom Oct 5, 2018
Merged
Fixed blue LED bug with cayenne LPP device#17johanstokking merged 2 commits intoTheThingsNetwork:masterfrom
johanstokking merged 2 commits intoTheThingsNetwork:masterfrom
Conversation
I had problems with my Things nodes (after several time, it freezes on fixed blue light). The problem has been solved on the forum (https://www.thethingsnetwork.org/forum/t/the-things-node-new-low-power-library-development/12521/144?u=simmoinard) and the Basics.ino has been update with a simple Delay(50), but not the CayenneLPP.ino ...
|
|
johanstokking
requested changes
Oct 5, 2018
Member
johanstokking
left a comment
There was a problem hiding this comment.
Thanks, good catch. Two minor code style things.
examples/CayenneLPP/CayenneLPP.ino
Outdated
| // Set RN module to sleep mode | ||
| ttn.sleep(60000); | ||
| // This one is not optionnal, remove it | ||
| // and say bye bye to RN2983 sleep mode |
Member
There was a problem hiding this comment.
Please remove comment. While you're at it, also on line 101.
Contributor
Author
|
Done ! |
johanstokking
approved these changes
Oct 5, 2018
Member
|
Thanks! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had problems with my Things nodes (after several time, it freezes on fixed blue light). The problem has been solved on the forum (https://www.thethingsnetwork.org/forum/t/the-things-node-new-low-power-library-development/12521/144?u=simmoinard)
The "Basics.ino" file has been updated with a simple Delay(50), but not the "CayenneLPP.ino" ...