Fixed decoder function for negative temperatures#11
Merged
johanstokking merged 1 commit intoTheThingsNetwork:masterfrom Feb 8, 2018
samvanbrussel:master
Merged
Fixed decoder function for negative temperatures#11johanstokking merged 1 commit intoTheThingsNetwork:masterfrom samvanbrussel:master
johanstokking merged 1 commit intoTheThingsNetwork:masterfrom
samvanbrussel:master
Conversation
|
|
johanstokking
approved these changes
Feb 8, 2018
Member
johanstokking
left a comment
There was a problem hiding this comment.
Thanks!
It's a cold winter indeed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When negative numbers in 2-complement get converted from 16-bit (Arduino) to 32-bit (JavaScript), the sign bit has to be at bit 0, not at bit 17, as it was with the old code, which implicitly padded 16 zeroes to the left. As a result, the negative number -1 returns 65535.
By prefixing a 16-bit negative number with 16 ones, the correct 32-bit 2-complement number is constructed.