Skip to content

fix intro/recap start_ms can be null and fix delete existing segments#7

Merged
Pasithea0 merged 2 commits into
TheIntroDB:mainfrom
bitxeno:main
May 7, 2026
Merged

fix intro/recap start_ms can be null and fix delete existing segments#7
Pasithea0 merged 2 commits into
TheIntroDB:mainfrom
bitxeno:main

Conversation

@bitxeno

@bitxeno bitxeno commented May 7, 2026

Copy link
Copy Markdown
Contributor

Description

  1. Reference documentation: https://theintrodb.org/docs. The start_ms for both the intro and the recap can be null.

  2. When IgnoreMediaWithExistingSegments is enabled, returning an empty array will cause Jellyfin to delete existing segments. To retain segments, need to return the existing segments array.
    Jellyfin code reference: https://github.com/jellyfin/jellyfin/blob/bc074b5283add16818ce598890f53ce9432cd4ad/Jellyfin.Server.Implementations/MediaSegments/MediaSegmentManager.cs#L127

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

bitxeno and others added 2 commits May 7, 2026 15:40
@Pasithea0 Pasithea0 merged commit b1679b4 into TheIntroDB:main May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants